DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=frogthinker.org;
	h=Received:Message-ID:Date:From:Organization:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=fQqevg6H79jXXfsjiU2dGmLS88Zt9CkymMz5G15jVk5JKQ3IjpFyMFjCKPNtiyR9DfRXe4TBR7bYFUUYxO2nexhdJ+dERynW8maFb+sdbjV7ZKg0ZHN1MUAegUY3LmVG;
Message-ID: <49476493.1080000@frogthinker.org>
Date: Tue, 16 Dec 2008 03:19:31 -0500
From: Emmanuel Cecchet <manu@frogthinker.org>
Organization: Frog Thinker
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
CC: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version
 1
References: <20081216153856.C013.52131E4D@oss.ntt.co.jp>
	<494759D0.1090002@frogthinker.org>
	<20081216163936.C016.52131E4D@oss.ntt.co.jp>
In-Reply-To: <20081216163936.C016.52131E4D@oss.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

ITAGAKI Takahiro wrote:
> The chained triggers would have better flexibilty, and the auto expanding
> trigger would have better usability. I'm not sure about performance
> because expanding child partitions is not always faster than chained
> calls of triggers.
>
> I think chained triggers are hard to maintain. If we drop one of partition
> tables, we need to reconnect the single-linked-list of the triggers.
>   
When you drop one child table, you would also have to drop the trigger 
that has the same name on the parent table.  This does not seem too hard 
but I may be missing something.
>>> server says "INSERT 0 row" though rows are inserted into child tables.
>>>       
>> Technically this is correct since 0 rows were inserted in the parent 
>> table.
>>     
> Yes, but users expect non-0 result normally. Some O/R mapping tools
> also checks the result exactly and raises errors (it could be turned
> off, but default is on).
>   
If the O/R mapping tool is also creating the table it should be aware of 
the semantics specifics to partition. But your comment is well taken, 
this seems counterintuitive and against most API semantics to return 0 
when the number of inserted rows is expected. This would certainly 
require some additional hooks to return the proper value.

Best regards,
Emmanuel
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
>   

-- 
Emmanuel Cecchet
FTO @ Frog Thinker 
Open Source Development & Consulting
--
Web: http://www.frogthinker.org
email: manu@frogthinker.org
Skype: emmanuel_cecchet