Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 7C15B63246E for ; Mon, 19 Jan 2009 13:17:24 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 08291-04 for ; Mon, 19 Jan 2009 13:17:18 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from hook.sigaev.ru (hook.sigaev.ru [212.192.243.50]) by mail.postgresql.org (Postfix) with ESMTP id C2C1E632445 for ; Mon, 19 Jan 2009 13:17:18 -0400 (AST) Received: by hook.sigaev.ru (Postfix, from userid 1003) id E27BA398F6; Mon, 19 Jan 2009 20:17:17 +0300 (MSK) Received: from xor.sai.msu.ru (xor.sai.msu.ru [212.192.243.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: teodor) by hook.sigaev.ru (Postfix) with ESMTPSA id 0936E398EF; Mon, 19 Jan 2009 20:17:14 +0300 (MSK) Message-ID: <4974B59A.1080302@sigaev.ru> Date: Mon, 19 Jan 2009 20:17:14 +0300 From: Teodor Sigaev User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.19) Gecko/20081222 SeaMonkey/1.1.14 MIME-Version: 1.0 To: Alvaro Herrera CC: Jeff Davis , Heikki Linnakangas , Tom Lane , Pgsql Hackers Subject: Re: [PATCHES] GIN improvements References: <486BC501.6060605@sigaev.ru> <27880.1215810535@sss.pgh.pa.us> <487A6E0C.3090600@sigaev.ru> <8993.1216843701@sss.pgh.pa.us> <4888A594.6010102@sigaev.ru> <490B07BA.6030109@sigaev.ru> <492F04D9.5070404@enterprisedb.com> <4942A137.3000502@sigaev.ru> <1229910966.2285.76.camel@jdavis> <49708008.8070109@sigaev.ru> <20090119171318.GE4132@alvh.no-ip.org> In-Reply-To: <20090119171318.GE4132@alvh.no-ip.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/1398 X-Sequence-Number: 132042 > I notice you added a fillfactor reloption in ginoptions, but does it > really make sense? I recall removing it because the original code > contained a comment that says "this is here because default_reloptions > wants it, but it has no effect". I didn't change a recognition of fillfactor value, although GIN doesn't use it for now. -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/