Message-ID: <497F15AF.1040800@enterprisedb.com>
Date: Tue, 27 Jan 2009 16:09:51 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Alvaro Herrera <alvherre@commandprompt.com>
CC: Simon Riggs <simon@2ndQuadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] Infrastructure changes for recovery
References: <1218109459.4549.423.camel@ebony.2ndQuadrant>
	<1220213074.4371.173.camel@ebony.2ndQuadrant>
	<1905.1220895241@sss.pgh.pa.us>
	<1221080797.3913.768.camel@ebony.2ndQuadrant>
	<20080912181421.GI8854@alvh.no-ip.org>
	<1221245766.3913.1130.camel@ebony.2ndQuadrant>
	<20080912193144.GJ8854@alvh.no-ip.org>
In-Reply-To: <20080912193144.GJ8854@alvh.no-ip.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

(replying to a very old message, since I just bumped into this in review)

Alvaro Herrera wrote:
> Simon Riggs wrote:
>> On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
>>> Simon Riggs wrote:
>>>
>>>> --- 5716,5725 ----
>>>>   						CheckpointStats.ckpt_sync_end_t,
>>>>   						&sync_secs, &sync_usecs);
>>>>   
>>>> ! 	elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
>>>>   		 "%d transaction log file(s) added, %d removed, %d recycled; "
>>>>   		 "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
>>>> + 		 (checkpoint ? "  checkpoint" : "restartpoint"),
>>>>   		 CheckpointStats.ckpt_bufs_written,
>>>>   		 (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
>>>>   		 CheckpointStats.ckpt_segs_added,
>>> Very minor nit: this really needs a rework.  
>> All I changed was the word "restartpoint"... its otherwise identical to
>> existing message. I'd rather not change that.
> 
> The new message is not translatable, the original was.

Doesn't really matter since it's an elog(), not ereport().

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com