Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id 5E5C263248B
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 19 Jan 2009 14:01:50 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 55959-03
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 19 Jan 2009 14:01:47 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id 10A36632481
	for <pgsql-hackers@postgresql.org>;
	Mon, 19 Jan 2009 14:01:46 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id n0JI0Q4q008326;
	Mon, 19 Jan 2009 13:00:26 -0500 (EST)
To: Alvaro Herrera <alvherre@commandprompt.com>
cc: Teodor Sigaev <teodor@sigaev.ru>, Jeff Davis <pgsql@j-davis.com>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] GIN improvements 
In-reply-to: <20090119172019.GF4132@alvh.no-ip.org> 
References: <487A6E0C.3090600@sigaev.ru> <8993.1216843701@sss.pgh.pa.us>
	<4888A594.6010102@sigaev.ru> <490B07BA.6030109@sigaev.ru>
	<492F04D9.5070404@enterprisedb.com>
	<4942A137.3000502@sigaev.ru> <1229910966.2285.76.camel@jdavis>
	<49708008.8070109@sigaev.ru> <20090119171318.GE4132@alvh.no-ip.org>
	<4974B59A.1080302@sigaev.ru> <20090119172019.GF4132@alvh.no-ip.org>
Comments: In-reply-to Alvaro Herrera <alvherre@commandprompt.com>
	message dated "Mon, 19 Jan 2009 14:20:19 -0300"
Date: Mon, 19 Jan 2009 13:00:26 -0500
Message-ID: <8325.1232388026@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200901/1402
X-Sequence-Number: 132046

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Teodor Sigaev wrote:
>> I didn't change a recognition of fillfactor value, although GIN doesn't 
>> use it for now.

> I suggest you take StdRdOptions out of the GinOptions struct, and leave
> fillfactor out of ginoptions.  I don't think there's much point in
> supporting options that don't actually do anything.  If the user tries
> to set fillfactor for a gin index, he will get an error.  Which is a
> good thing IMHO.

+1 ... appearing to accept an option that doesn't really do anything is
likely to confuse users.  We didn't have much choice in the previous
incarnation of reloptions, but I think now we should throw errors when
we can.

			regards, tom lane