Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id E6D3B6324E0 for ; Tue, 20 Jan 2009 18:14:04 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 85449-01 for ; Tue, 20 Jan 2009 18:13:56 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from westnet.com (westnet.com [216.187.52.2]) by mail.postgresql.org (Postfix) with ESMTP id C38EF632457 for ; Tue, 20 Jan 2009 18:13:56 -0400 (AST) Received: from westnet.com (localhost [127.0.0.1]) by westnet.com (8.14.0/8.14.0) with ESMTP id n0KMDrNL004762; Tue, 20 Jan 2009 17:13:53 -0500 (EST) Received: from localhost (gsmith@localhost) by westnet.com (8.14.0/8.13.2/Submit) with ESMTP id n0KMDraD004757; Tue, 20 Jan 2009 17:13:53 -0500 (EST) X-Authentication-Warning: westnet.com: gsmith owned process doing -bs Date: Tue, 20 Jan 2009 17:13:53 -0500 (EST) From: Greg Smith X-X-Sender: gsmith@westnet.com To: Bryce Nesbitt cc: Pgsql Hackers Subject: Re: New pg_dump patch, --no-stats flag, disables sending to statistics collector In-Reply-To: <49763C47.7070400@obviously.com> Message-ID: References: <483FD205.4090904@sigaev.ru> <486BC501.6060605@sigaev.ru> <27880.1215810535@sss.pgh.pa.us> <487A6E0C.3090600@sigaev.ru> <8993.1216843701@sss.pgh.pa.us> <4888A594.6010102@sigaev.ru> <490B07BA.6030109@sigaev.ru> <492F04D9.5070404@enterprisedb.com> <4942A137.3000502@sigaev.ru> <1229910966.2285.76.camel@jdavis> <49708008.8070109@sigaev.ru> <1232348905.7281.114.camel@jdavis> <4974B002.3040202@sigaev.ru> <1232474489.23316.8.camel@jdavis> <49763C47.7070400@obviously.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/1481 X-Sequence-Number: 132125 On Tue, 20 Jan 2009, Bryce Nesbitt wrote: > This patch adds another flag to pg_dump, this time to disable statistics > collection. You can pass session parameters to anything that uses the standard libpq library using PGOPTIONS. See http://www.postgresql.org/docs/8.3/static/config-setting.html for a sample. I suspect that something like: PGOPTIONS='-c stats_block_level=false -c stats_row_level=false' pg_dump would do the same thing as your patch without having to touch the code. That's a pretty obscure bit of information though, and it would be worthwhile to update the documentation suggesting such a syntax because I think this would be handy for a lot of people. I was already planning to do that for another use case (pgbench) once the 8.4 work here shifts from development to testing and I have some more time for writing. -- * Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD