Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id B1017650158 for ; Tue, 8 Jul 2008 13:10:56 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 12518-07 for ; Tue, 8 Jul 2008 13:10:50 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183]) by postgresql.org (Postfix) with ESMTP id 71BBC650125 for ; Tue, 8 Jul 2008 13:10:47 -0300 (ADT) Received: by wa-out-1112.google.com with SMTP id n4so1614445wag.5 for ; Tue, 08 Jul 2008 09:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=FP0yciZf/udYOzDW64Lm4e1Ih8h2M7fAp1pNoD//kQw=; b=U6d3r8CB3uAxJzKLeFwQcFWRQKlMuPjzgnnVotkbQ4QlbRu+3j0aP8SRSk02fO9NXx 07hq1fhH2ZubGuCRohEeirw1OrqoS4tYpMKjr+E1aNduIHenvaTvFnUXC2hVAL9VNsnG CvpnxGXoQPg+WWILL0HcULXbM+UpAgf6AxzC0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=iI82CqblRn6IRMrPkYZY7FXUpxuerIF3PJtfNaYWAnCddIXh9AP5RcR0vOONvebUpO dfY7LIbOuVS38qCZSDvULO6sP/WgKqZdcNIS4ylAw3UFIqensU69kq2+/aviTUCWUIoI uH2GRD/s19grlN+CeVDtLSk4TdVC8A+Sxjb84= Received: by 10.114.73.14 with SMTP id v14mr969947waa.163.1215533446119; Tue, 08 Jul 2008 09:10:46 -0700 (PDT) Received: by 10.114.131.6 with HTTP; Tue, 8 Jul 2008 09:10:45 -0700 (PDT) Message-ID: Date: Tue, 8 Jul 2008 11:10:45 -0500 From: "Jaime Casanova" To: "Alvaro Herrera" Subject: Re: [PATCHES] Extending grant insert on tables to sequences Cc: pgsql-patches , "Pg Hackers" In-Reply-To: <20080708133244.GB4095@alvh.no-ip.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20080708133244.GB4095@alvh.no-ip.org> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200807/408 X-Sequence-Number: 120668 On 7/8/08, Alvaro Herrera wrote: > Jaime Casanova escribi=F3: > > On Thu, May 22, 2008 at 1:18 PM, Jaime Casanova wrote: > > > Hi, > > > > > > The idea of this patch is to avoid the need to make explicit grants o= n > > > sequences owned by tables. > > > > I've noted that the patch i attached is an older version that doesn't > > compile because of a typo... > > Re-attaching right patch and fix documentation to indicate the new beha= viour... > > I had a look at this patch and it looks good. The only thing that's not > clear to me is whether we have agreed we want this to be the default > behavior? > mmm... i don't remember from where i took the equivalences... i will review if there is any concensus in that... anyway now i when people should speak about it... > > Wouldn't it be clearer to build a list with all the sequences owned by > the tables in istmt.objects, and then call ExecGrantStmt_oids() a single > time with the big list? > at night i will see the code for this... --=20 regards, Jaime Casanova Soporte y capacitaci=F3n de PostgreSQL Guayaquil - Ecuador Cel. (593) 87171157