Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 399971337BC8 for ; Fri, 5 Nov 2010 17:23:11 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 99998-09 for ; Fri, 5 Nov 2010 20:23:04 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id A04401337B81 for ; Fri, 5 Nov 2010 17:23:03 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id oA5KN0Ai001037; Fri, 5 Nov 2010 16:23:00 -0400 (EDT) To: "Kevin Grittner" cc: "Merlin Moncure" , "Robert Haas" , "Jon Nelson" , pgsql-bugs@postgresql.org Subject: Re: [PERFORM] typoed column name, but postgres didn't grump In-reply-to: <4CD41F9A020000250003737F@gw.wicourts.gov> References: <4480.1288374498@sss.pgh.pa.us> <4CCACE6E0200002500036F95@gw.wicourts.gov> <6240.1288379246@sss.pgh.pa.us> <4CCADE440200002500036FB2@gw.wicourts.gov> <8216.1288383162@sss.pgh.pa.us> <4CD28C5C020000250003727B@gw.wicourts.gov> <9974.1288887285@sss.pgh.pa.us> <11057.1288889780@sss.pgh.pa.us><11057.1288889780@sss.pgh.pa.us> <29497.1288984644@sss.pgh.pa.us> <4CD41F9A020000250003737F@gw.wicourts.gov> Comments: In-reply-to "Kevin Grittner" message dated "Fri, 05 Nov 2010 15:15:38 -0500" Date: Fri, 05 Nov 2010 16:23:00 -0400 Message-ID: <1036.1288988580@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201011/43 X-Sequence-Number: 28623 "Kevin Grittner" writes: > Tom Lane wrote: >> Here's a proposed patch, sans documentation as yet. > I see you took the surgical approach -- only a cast from a record to > a character string type is affected. I agree that will fix the > complaints I've seen, and I imagine you're keeping the change narrow > to minimize the risk of breaking existing code, but this still looks > weird to me: > test=# select ('2010-11-05'::date).text; > text > ------------ > 2010-11-05 > (1 row) Perhaps, but it's been accepted since 7.3, with few complaints. I think we should only remove the behavior that was added in 8.4. regards, tom lane