thread-index: AccqgvSFca2XwWIYSYiIa2Qe8Ohq8A==
Content-Class: urn:content-classes:message
Importance: normal
Subject: Re: Advice on selecting good values for work_mem?
From: "Simon Riggs" <simon@2ndquadrant.com>
To: "Bill Moran" <wmoran@collaborativefusion.com>
Cc: "Tom Lane" <tgl@sss.pgh.pa.us>,
	<pgsql-performance@postgresql.org>
In-Reply-To: <20061218161805.04699b10.wmoran@collaborativefusion.com>
References: <20061207113531.98095b27.wmoran@collaborativefusion.com>
	<16388.1165510978@sss.pgh.pa.us>
	<20061218161805.04699b10.wmoran@collaborativefusion.com>
Content-Type: text/plain;
	charset="iso-8859-1"
Date: Thu, 28 Dec 2006 13:19:44 +0000
Message-ID: <1167311984.3633.87.camel@silverbirch.site>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

On Mon, 2006-12-18 at 16:18 -0500, Bill Moran wrote: 
> In response to Tom Lane <tgl@sss.pgh.pa.us>:
> 
> > Bill Moran <wmoran@collaborativefusion.com> writes:
> > > Does the creation of a temp file trigger any logging?
> > 
> > No; but it wouldn't be hard to add some if you wanted.  I'd do it at
> > deletion, not creation, so you could log the size the file reached.
> > See FileClose() in src/backend/storage/file/fd.c.
> 
> Is this along the lines of what you were thinking?  Is this acceptable
> to get pulled into the tree (maintaining local patches sucks ;)  I've
> only been using this patch a day and I'm already giddy about how much
> it helps tuning work memory sizes ...

You need to submit to patches, not here. Patch looks right, but needs
some extra things:

- activate based upon a GUC called trace_temp_files (?) to be added in
src/backend/utils/misc/guc.c - using a temp file is a problem only in
the eye of the beholder, so let the admin decide whether to show the
info or not (default not)

- level LOG not WARNING, with no hint message (?)

- message should be something like "temp file: size %s path: %s" so we
can see where the file was created (there is another todo about creating
temp files in different locations)

- add a trace point also for those who don't want to enable a parameter,
described here
http://www.postgresql.org/docs/8.2/static/dynamic-trace.html

e.g. PGTRACE1(temp__file__cleanup, filestats.st_size)


-- 
  Simon Riggs             
  EnterpriseDB   http://www.enterprisedb.com