X-Original-To: pgsql-performance-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id CB33AD1BA68; Thu, 18 Mar 2004 20:09:15 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 93313-08; Thu, 18 Mar 2004 16:09:03 -0400 (AST) Received: from sss.pgh.pa.us (unknown [192.204.191.242]) by svr1.postgresql.org (Postfix) with ESMTP id 797C8D1D2BC; Thu, 18 Mar 2004 16:08:55 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i2IK8nS1011719; Thu, 18 Mar 2004 15:08:49 -0500 (EST) To: Bruce Momjian Cc: Mark Kirkwood , pgsql-performance@postgresql.org, PostgreSQL-development Subject: Re: [HACKERS] fsync method checking In-reply-to: <200403181955.i2IJtT721737@candle.pha.pa.us> References: <200403181955.i2IJtT721737@candle.pha.pa.us> Comments: In-reply-to Bruce Momjian message dated "Thu, 18 Mar 2004 14:55:29 -0500" Date: Thu, 18 Mar 2004 15:08:48 -0500 Message-ID: <11718.1079640528@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/264 X-Sequence-Number: 6120 Bruce Momjian writes: > Tom Lane wrote: >> It's what tested out as the best bet. I think we were using pgbench >> as the test platform, which as you know I have doubts about, but at >> least it is testing one actual write/sync pattern Postgres can generate. > I assume pgbench has so much variance that trying to see fsync changes > in there would be hopeless. The results were fairly reproducible, as I recall; else we'd have looked for another test method. You may want to go back and consult the pghackers archives. >> * Some of the test cases count open()/close() overhead, some don't. > The only one I saw that had an extra open() was the fsync after close > test. I add a do-nothing open/close to the previous test so they are > the same. Why is it sensible to include open/close overhead in the "simple write" case and not in the "o_sync write" cases, for instance? Doesn't seem like a fair comparison to me. Adding the open overhead to all cases might make it "fair", but it would also make it not what we want to measure. >> * The program is claimed to test whether you can write from one process >> and fsync from another, but it does no such thing AFAICS. > It really just shows whether the fsync fater the close has similar > timing to the one before the close. That was the best way I could think > to test it. Sure, but where's the "separate process" part? What this seems to test is whether a single process can sync its own writes through a different file descriptor; which is interesting but by no means the only thing we need to be sure of if we want to make the bgwriter handle syncing. regards, tom lane