X-Original-To: pgsql-performance-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 0A375D1B169 for ; Fri, 11 Jun 2004 18:30:50 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 38308-06 for ; Fri, 11 Jun 2004 21:30:51 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id CC2CDD1B175 for ; Fri, 11 Jun 2004 18:30:48 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i5BLUodw018743; Fri, 11 Jun 2004 17:30:50 -0400 (EDT) To: "Merlin Moncure" Cc: pgsql-performance@postgresql.org Subject: Re: in-transaction insert performance in 7.5devel In-reply-to: <6EE64EF3AB31D5448D0007DD34EEB34101AE5B@Herge.rcsinc.local> References: <6EE64EF3AB31D5448D0007DD34EEB34101AE5B@Herge.rcsinc.local> Comments: In-reply-to "Merlin Moncure" message dated "Fri, 11 Jun 2004 17:04:44 -0400" Date: Fri, 11 Jun 2004 17:30:50 -0400 Message-ID: <18742.1086989450@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200406/140 X-Sequence-Number: 7198 "Merlin Moncure" writes: > Tom Lane wrote: >> Does it help if you change FlushBuffer to release buffer lock while >> flushing xlog? > Putting your change in resulted in about a 15% increase in insert > performance. There may be some quirky things going on here with NTFS... > I did an update clean from cvs and I noticed big speedup across the > board. Right now sync performance is right in line with my > expectations. In any case, I checked and confirm that there are no > spurious fsyncs running when they are not supposed to be. Was that 15% before or after updating from CVS? The more I think about the looping aspect the less I like it, so I'd prefer not to pursue making the unlock change for real. But if it's really a 15% win then maybe we need to... regards, tom lane