Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrQMh-0008Gp-Js for pgsql-performance@arkaria.postgresql.org; Thu, 10 Jun 2021 19:29:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lrQMf-00013c-B3 for pgsql-performance@arkaria.postgresql.org; Thu, 10 Jun 2021 19:29:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrQMf-00013U-2z for pgsql-performance@lists.postgresql.org; Thu, 10 Jun 2021 19:29:17 +0000 Received: from aws.mailpen.com ([52.43.43.172] helo=aws2.mailpen.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrQMY-0005p8-US for pgsql-performance@postgresql.org; Thu, 10 Jun 2021 19:29:13 +0000 Received: from [172.20.70.208] (unknown [50.35.114.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by aws2.mailpen.com (Postfix) with ESMTPSA id A7785C64F7F; Thu, 10 Jun 2021 12:29:05 -0700 (PDT) Subject: Re: AWS forcing PG upgrade from v9.6 a disaster To: pgsql-performance@postgresql.org References: <88dec70b-eb63-0b72-0b5d-253851ef127b@mailpen.com> <92cc8563-195f-8727-d887-5f2bb63f231f@mailpen.com> <20210601041635.GQ2082@telsasoft.com> <18f77a0c-dade-b86a-cbeb-6f85d3d137e1@dunslane.net> <4abbbebd-1496-7376-136f-38eb91773cd2@mailpen.com> <1682562.1623348017@sss.pgh.pa.us> From: "Dean Gibson (DB Administrator)" Organization: UltiMeth Systems Message-ID: <1921658f-4827-e89b-9ecf-68bf6e0d212a@mailpen.com> Date: Thu, 10 Jun 2021 12:29:05 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------937BEFAA3BCD96389310F457" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------937BEFAA3BCD96389310F457 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 2021-06-10 11:23, Andrew Dunstan wrote: > On 6/10/21 2:00 PM, Tom Lane wrote: >> "Dean Gibson (DB Administrator)" writes: >>> ... Do I need quotes on the command line? >>> On 2021-06-10 09:54, Ranier Vilela wrote: >>>> Your cmd lacks = >>>> =>pg_dumpall -U Admin --exclude-database=MailPen >zzz.sql >>> I read [the manual] before posting, but missed that. Old command line patterns die hard! >>> However, the result was the same: 3.5GB before running out of space. >> [ experiments... ] Looks like you gotta do it like this: >> >> pg_dumpall '--exclude-database="MailPen"' ... >> >> This surprises me, as I thought it was project policy not to case-fold command-line arguments (precisely because you end up needing weird quoting to prevent that). > Ouch. That looks like a plain old bug. Let's fix it. IIRC I just used the same logic that we use for pg_dump's --exclude-* options, so we need to check if they have similar issues. > > cheers, andrew That works!  I thought it was a quoting/case issue!  I was next going to try single quotes just outside double quotes, & that works as well (& is a bit more natural): pg_dumpall -U Admin --exclude-database='"MailPen"' >zzz.sql Using mixed case has bitten me before, but I am not deterred!  I run phpBB 3.0.14 (very old version) because upgrades to more current versions fail on the mixed case of the DB name, as well as the use of SCHEMAs to isolate the message board from the rest of the data. Yes, I reported it years ago. I use lower-case for column, VIEW, & function names;  mixed (camel) case for table, schema, & database names;  & upper-case for SQL keywords.  It helps readability (as does murdering a couple semicolons in the prior sentence). --------------937BEFAA3BCD96389310F457 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
On 2021-06-10 11:23, Andrew Dunstan wrote:
On 6/10/21 2:00 PM, Tom Lane wrote:

"Dean Gibson (DB Administrator)" <postgresql@mailpen.com> writes:

... Do I need quotes on the command line?

On 2021-06-10 09:54, Ranier Vilela wrote:

Your cmd lacks =
=>pg_dumpall -U Admin --exclude-database=MailPen >zzz.sql

I read [the manual] before posting, but missed that.  Old command line patterns die hard!
However, the result was the same:  3.5GB before running out of space.

[ experiments... ]  Looks like you gotta do it like this:

	pg_dumpall '--exclude-database="MailPen"' ...

This surprises me, as I thought it was project policy not to case-fold command-line arguments (precisely because you end up needing weird quoting to prevent that).	

Ouch. That looks like a plain old bug. Let's fix it. IIRC I just used the same logic that we use for pg_dump's --exclude-* options, so we need to check if they have similar issues.

cheers, andrew

That works!  I thought it was a quoting/case issue!  I was next going to try single quotes just outside double quotes, & that works as well (& is a bit more natural):

pg_dumpall -U Admin --exclude-database='"MailPen"' >zzz.sql

Using mixed case has bitten me before, but I am not deterred!  I run phpBB 3.0.14 (very old version) because upgrades to more current versions fail on the mixed case of the DB name, as well as the use of SCHEMAs to isolate the message board from the rest of the data.  Yes, I reported it years ago.

I use lower-case for column, VIEW, & function names;  mixed (camel) case for table, schema, & database names;  & upper-case for SQL keywords.  It helps readability (as does murdering a couple semicolons in the prior sentence).

--------------937BEFAA3BCD96389310F457--