pg.ddx.io pgsql-performance@postgresql.org mailing list archive
help / color / mirror / Atom feedpg_dumpall --exclude-database case folding, was Re: AWS forcing PG upgrade from v9.6 a disaster
3+ messages / 2 participants
[nested] [flat]
* pg_dumpall --exclude-database case folding, was Re: AWS forcing PG upgrade from v9.6 a disaster
@ 2021-06-14 13:21 Andrew Dunstan <andrew@dunslane.net>
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Dunstan @ 2021-06-14 13:21 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; Dean Gibson (DB Administrator) <postgresql@mailpen.com>; +Cc: pgsql-performance
On 6/10/21 2:23 PM, Andrew Dunstan wrote:
> On 6/10/21 2:00 PM, Tom Lane wrote:
>> "Dean Gibson (DB Administrator)" <postgresql@mailpen.com> writes:
>>> On 2021-06-10 09:54, Ranier Vilela wrote:
>>>> Your cmd lacks =
>>>> =>pg_dumpall -U Admin --exclude-database=MailPen >zzz.sql
>>> I read that before posting, but missed that. Old command line patterns
>>> die hard!
>>> However, the result was the same: 3.5GB before running out of space.
>> [ experiments... ] Looks like you gotta do it like this:
>>
>> pg_dumpall '--exclude-database="MailPen"' ...
>>
>> This surprises me, as I thought it was project policy not to
>> case-fold command-line arguments (precisely because you end
>> up needing weird quoting to prevent that).
>>
>>
>
>
> Ouch. That looks like a plain old bug. Let's fix it. IIRC I just used
> the same logic that we use for pg_dump's --exclude-* options, so we need
> to check if they have similar issues.
>
>
Peter Eisentraut has pointed out to me that this is documented, albeit a
bit obscurely for pg_dumpall. But it is visible on the pg_dump page.
Nevertheless, it's a bit of a POLA violation as we've seen above, and
I'd like to get it fixed, if there's agreement, both for this pg_dumpall
option and for pg_dump's pattern matching options.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pg_dumpall --exclude-database case folding, was Re: AWS forcing PG upgrade from v9.6 a disaster
@ 2021-06-14 13:32 Tom Lane <tgl@sss.pgh.pa.us>
parent: Andrew Dunstan <andrew@dunslane.net>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2021-06-14 13:32 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Dean Gibson (DB Administrator) <postgresql@mailpen.com>; pgsql-performance
Andrew Dunstan <andrew@dunslane.net> writes:
> On 6/10/21 2:23 PM, Andrew Dunstan wrote:
>> Ouch. That looks like a plain old bug. Let's fix it. IIRC I just used
>> the same logic that we use for pg_dump's --exclude-* options, so we need
>> to check if they have similar issues.
> Peter Eisentraut has pointed out to me that this is documented, albeit a
> bit obscurely for pg_dumpall. But it is visible on the pg_dump page.
Hmm.
> Nevertheless, it's a bit of a POLA violation as we've seen above, and
> I'd like to get it fixed, if there's agreement, both for this pg_dumpall
> option and for pg_dump's pattern matching options.
+1, but the -performance list isn't really where to hold that discussion.
Please start a thread on -hackers.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* pg_dumpall --exclude-database case folding
@ 2021-06-14 13:46 Andrew Dunstan <andrew@dunslane.net>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Dunstan @ 2021-06-14 13:46 UTC (permalink / raw)
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
[discussion transferred from psql-performance]
Summary: pg_dumpall and pg_dump fold non-quoted commandline patterns to
lower case
Tom lane writes:
Andrew Dunstan <andrew@dunslane.net> writes:
> On 6/10/21 2:23 PM, Andrew Dunstan wrote:
>> Ouch. That looks like a plain old bug. Let's fix it. IIRC I just used
>> the same logic that we use for pg_dump's --exclude-* options, so we need
>> to check if they have similar issues.
> Peter Eisentraut has pointed out to me that this is documented, albeit a
> bit obscurely for pg_dumpall. But it is visible on the pg_dump page.
Hmm.
> Nevertheless, it's a bit of a POLA violation as we've seen above, and
> I'd like to get it fixed, if there's agreement, both for this pg_dumpall
> option and for pg_dump's pattern matching options.
+1, but the -performance list isn't really where to hold that discussion.
Please start a thread on -hackers.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-06-14 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14 13:21 pg_dumpall --exclude-database case folding, was Re: AWS forcing PG upgrade from v9.6 a disaster Andrew Dunstan <andrew@dunslane.net>
2021-06-14 13:32 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-06-14 13:46 ` pg_dumpall --exclude-database case folding Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox