Subject: Re: pg_upgrade 10.2
To: Murthy Nunna <mnunna@fnal.gov>,
 "pgsql-general@lists.postgresql.org" <pgsql-general@lists.postgresql.org>,
 "pgsql-admin@lists.postgresql.org" <pgsql-admin@lists.postgresql.org>,
 "pgsql-performance@lists.postgresql.org"
 <pgsql-performance@lists.postgresql.org>
References: 
 <DM5PR09MB15157D85EB291E8F7EA62E25B87F0@DM5PR09MB1515.namprd09.prod.outlook.com>
From: Adrian Klaver <adrian.klaver@aklaver.com>
Message-ID: <1a3ebd40-7870-3eab-97d4-ca2b9907d917@aklaver.com>
Date: Tue, 12 Jun 2018 13:47:30 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: 
 <DM5PR09MB15157D85EB291E8F7EA62E25B87F0@DM5PR09MB1515.namprd09.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06/12/2018 01:34 PM, Murthy Nunna wrote:
> In older versions of pg_upgrade (e.g from 9.2 to 9.3), I was able to run 
> pg_upgrade without stopping old cluster using the check flag.
> 
> pg_upgrade -b <old-bin> -B <new-bin> -d <old-data> -D <new-data> -p 5432 
> -P 5434 -r -v -k -c
> 
> Note the “c” flag at the end

I take the below to it mean it should work:

https://www.postgresql.org/docs/10/static/pgupgrade.html
> "You can use pg_upgrade --check to perform only the checks, even if the 
old server is still running. pg_upgrade --check will also outline any 
manual adjustments you will need to make after the upgrade. If you are 
going to be using link mode, you should use the --link option with 
--check to enable link-mode-specific checks."

Might want to try without -k to see what happens.

More comments below.

> However pg_upgrade in 10 (I tried from 9.3 to 10.4), when I did not stop 
> the old cluster, the upgrade failed:
> 
> ***
> 
> There seems to be a postmaster servicing the old cluster.
> 
> Please shutdown that postmaster and try again.
> 
> Failure, exiting
> 
> Is this expected?
> 
> Also, when I stopped the old cluster and ran pg_upgrade with “-c” flag, 
> the file global/pg_control got renamed to global/pg_control.old. The 
> “-c” flag never renamed anything in the old cluster in older pg_upgrade

Again seems related to -k:

"
If you ran pg_upgrade without --link or did not start the new server, 
the old cluster was not modified except that, if linking started, a .old 
suffix was appended to $PGDATA/global/pg_control. To reuse the old 
cluster, possibly remove the .old suffix from $PGDATA/global/pg_control; 
you can then restart the old cluster.
"
> 


-- 
Adrian Klaver
adrian.klaver@aklaver.com