X-Original-To: pgsql-committers@postgresql.org Received: from perrin.int.nxad.com (internal.ext.nxad.com [69.1.70.251]) by postgresql.org (Postfix) with ESMTP id 78C98475C15 for ; Mon, 10 Mar 2003 23:56:32 -0500 (EST) Received: by perrin.int.nxad.com (Postfix, from userid 1001) id DF2A62105B; Mon, 10 Mar 2003 20:56:10 -0800 (PST) Date: Mon, 10 Mar 2003 20:56:10 -0800 From: Sean Chittenden To: Neil Conway Cc: Christopher Kings-Lynne , "Marc G. Fournier" , Tom Lane , pgsql-committers@postgresql.org Subject: Re: pgsql-server/ /configure /configure.in rc/incl ... Message-ID: <20030311045610.GF79234@perrin.int.nxad.com> References: <20030306031656.1876F4762E0@postgresql.org> <032f01c2e390$b1842b20$6500a8c0@fhp.internal> <11077.1046921667@sss.pgh.pa.us> <033f01c2e392$71476570$6500a8c0@fhp.internal> <12228.1046922471@sss.pgh.pa.us> <20030306094117.GA79234@perrin.int.nxad.com> <20030310224706.T35660@hub.org> <20030311041133.GC79234@perrin.int.nxad.com> <018201c2e785$2c12c750$6500a8c0@fhp.internal> <1047357755.357.1.camel@tokyo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1047357755.357.1.camel@tokyo> User-Agent: Mutt/1.4i X-PGP-Key: finger seanc@FreeBSD.org X-PGP-Fingerprint: 3849 3760 1AFE 7B17 11A0 83A6 DD99 E31F BC84 B341 X-Web-Homepage: http://sean.chittenden.org/ X-Archive-Number: 200303/62 X-Sequence-Number: 9305 > > It would be nice to have this support there, however Tom was > > correct in saying it really only applies to network apps that are > > handling thousands of connections, all really, really fast. > > Postgres doesn't. I say you'd have to do the work, then do the > > benchmarking to see if it makes a difference. > > ... and if it doesn't make a significant difference, I'd oppose > including it in the mainline source. Performance optimization is one > thing; performance "optimization" that doesn't actually improve > performance is another :-) ::sigh:: Well, I'm not about to argue one way or another on this beyond saying: kqueue is better than select/poll, but there are much bigger, much lower, and much easier pieces of fruit to pick off the optimization tree given the cost/benefit for the amount of network IO PostgreSQL does. That said, what was the performance gain of moving from select() to poll()? It wasn't the biggest optimization in PostgreSQL history, nor the smallest, but it was a step forward. -sc -- Sean Chittenden