X-Original-To: pgsql-hackers@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id 91361475CA9 for ; Sun, 20 Apr 2003 12:04:11 -0400 (EDT) Received: from megazone.bigpanda.com (megazone.bigpanda.com [63.150.15.178]) by postgresql.org (Postfix) with ESMTP id 04EA647580B for ; Sun, 20 Apr 2003 12:04:07 -0400 (EDT) Received: by megazone.bigpanda.com (Postfix, from userid 1001) id D5AE0D611; Sun, 20 Apr 2003 09:04:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by megazone.bigpanda.com (Postfix) with ESMTP id C11865C03; Sun, 20 Apr 2003 09:04:10 -0700 (PDT) Date: Sun, 20 Apr 2003 09:04:10 -0700 (PDT) From: Stephan Szabo To: Tom Lane Cc: Kevin Brown , Subject: Re: [PERFORM] Foreign key performance In-Reply-To: <20030419235530.S23637-100000@megazone23.bigpanda.com> Message-ID: <20030420090304.F28973-200000@megazone23.bigpanda.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-176117628-1050854650=:28973" X-Spam-Status: No, hits=-13.0 required=5.0 tests=BAYES_01,IN_REP_TO,QUOTED_EMAIL_TEXT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-Archive-Number: 200304/723 X-Sequence-Number: 38213 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-176117628-1050854650=:28973 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sat, 19 Apr 2003, Stephan Szabo wrote: > On Sat, 19 Apr 2003, Tom Lane wrote: > > > Stephan Szabo writes: > > > The hack was just the keeping around the list pointer from the last run > > > through (see attached - passed simple fk tests and regression, but there > > > might be problems I don't see). > > > > Shouldn't this patch update the comment in deferredTriggerInvokeEvents > > (c. line 1860 in cvs tip)? > > Probably, since the second part of that is basically what this is. I'll > update and send updated patch tomorrow. Okay, this changes the second paragraph of that comment. I left in the comment that's really similar next to where I actually do the selection of which start point to use. --0-176117628-1050854650=:28973 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="trigger.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20030420090410.N28973@megazone23.bigpanda.com> Content-Description: Content-Disposition: attachment; filename="trigger.patch" SW5kZXg6IHNyYy9iYWNrZW5kL2NvbW1hbmRzL3RyaWdnZXIuYw0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9wcm9qZWN0cy9jdnNyb290 L3Bnc3FsLXNlcnZlci9zcmMvYmFja2VuZC9jb21tYW5kcy90cmlnZ2VyLmMs dg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE0Nw0KZGlmZiAtYyAtcjEuMTQ3 IHRyaWdnZXIuYw0KKioqIHNyYy9iYWNrZW5kL2NvbW1hbmRzL3RyaWdnZXIu YwkyMDAzLzAzLzMxIDIwOjQ3OjUxCTEuMTQ3DQotLS0gc3JjL2JhY2tlbmQv Y29tbWFuZHMvdHJpZ2dlci5jCTIwMDMvMDQvMjAgMTY6MDE6NTUNCioqKioq KioqKioqKioqKg0KKioqIDE2MjYsMTYzNyAqKioqDQotLS0gMTYyNiwxNjQz IC0tLS0NCiAgICogQmVjYXVzZSB0aGlzIGNhbiBncm93IHByZXR0eSBsYXJn ZSwgd2UgZG9uJ3QgdXNlIHNlcGFyYXRlIExpc3Qgbm9kZXMsDQogICAqIGJ1 dCBpbnN0ZWFkIHRocmVhZCB0aGUgbGlzdCB0aHJvdWdoIHRoZSBkdGVfbmV4 dCBmaWVsZHMgb2YgdGhlIG1lbWJlcg0KICAgKiBub2Rlcy4gIFNhdmVzIGp1 c3QgYSBmZXcgYnl0ZXMgcGVyIGVudHJ5LCBidXQgdGhhdCBhZGRzIHVwLg0K KyAgKiANCisgICogZGVmdHJpZ19ldmVudHNfaW1tIGhvbGRzIHRoZSB0YWls IHBvaW50ZXIgYXMgb2YgdGhlIGxhc3QgDQorICAqIGRlZmVycmVkVHJpZ2dl ckludm9rZUV2ZW50cyBjYWxsLCBzaW5jZSBnZW5lcmFsbHkgaW1tZWRpYXRl IHRyaWdnZXJzDQorICAqIGNhbid0IGV4aXN0IGJlZm9yZSB0aGlzIHBvaW50 IChzaW5jZSB0aGV5IHNob3VsZCBhbHJlYWR5IGhhdmUgYmVlbg0KKyAgKiBj YWxsZWQpIGV4Y2VwdGluZyBTRVQgQ09OU1RSQUlOVFMNCiAgICoNCiAgICog WFhYIE5lZWQgdG8gYmUgYWJsZSB0byBzaG92ZSB0aGlzIGRhdGEgb3V0IHRv IGEgZmlsZSBpZiBpdCBncm93cyB0b28NCiAgICoJICAgbGFyZ2UuLi4NCiAg ICogLS0tLS0tLS0tLQ0KICAgKi8NCiAgc3RhdGljIERlZmVycmVkVHJpZ2dl ckV2ZW50IGRlZnRyaWdfZXZlbnRzOw0KKyBzdGF0aWMgRGVmZXJyZWRUcmln Z2VyRXZlbnQgZGVmdHJpZ19ldmVudHNfaW1tOw0KICBzdGF0aWMgRGVmZXJy ZWRUcmlnZ2VyRXZlbnQgZGVmdHJpZ19ldmVudF90YWlsOw0KICANCiAgDQoq KioqKioqKioqKioqKioNCioqKiAxODQ0LDE4NTAgKioqKg0KICBzdGF0aWMg dm9pZA0KICBkZWZlcnJlZFRyaWdnZXJJbnZva2VFdmVudHMoYm9vbCBpbW1l ZGlhdGVfb25seSkNCiAgew0KISAJRGVmZXJyZWRUcmlnZ2VyRXZlbnQgZXZl bnQsDQogIAkJCQlwcmV2X2V2ZW50ID0gTlVMTDsNCiAgCU1lbW9yeUNvbnRl eHQgcGVyX3R1cGxlX2NvbnRleHQ7DQogIAlSZWxhdGlvbglyZWwgPSBOVUxM Ow0KLS0tIDE4NTAsMTg1NiAtLS0tDQogIHN0YXRpYyB2b2lkDQogIGRlZmVy cmVkVHJpZ2dlckludm9rZUV2ZW50cyhib29sIGltbWVkaWF0ZV9vbmx5KQ0K ICB7DQohIAlEZWZlcnJlZFRyaWdnZXJFdmVudCBldmVudCA9IE5VTEwsDQog IAkJCQlwcmV2X2V2ZW50ID0gTlVMTDsNCiAgCU1lbW9yeUNvbnRleHQgcGVy X3R1cGxlX2NvbnRleHQ7DQogIAlSZWxhdGlvbglyZWwgPSBOVUxMOw0KKioq KioqKioqKioqKioqDQoqKiogMTg1NywxODgwICoqKioNCiAgCSAqIGFyZSBn b2luZyB0byBkaXNjYXJkIHRoZSB3aG9sZSBldmVudCBxdWV1ZSBvbiByZXR1 cm4gYW55d2F5LCBzbyBubw0KICAJICogbmVlZCB0byBib3RoZXIgd2l0aCAi cmV0YWlsIiBwZnJlZSdzLg0KICAJICoNCiEgCSAqIEluIGEgc2NlbmFyaW8g d2l0aCBtYW55IGNvbW1hbmRzIGluIGEgdHJhbnNhY3Rpb24gYW5kIG1hbnkN CiEgCSAqIGRlZmVycmVkLXRvLWVuZC1vZi10cmFuc2FjdGlvbiB0cmlnZ2Vy cywgaXQgY291bGQgZ2V0IGFubm95aW5nIHRvDQohIAkgKiByZXNjYW4gYWxs IHRoZSBkZWZlcnJlZCB0cmlnZ2VycyBhdCBlYWNoIGNvbW1hbmQgZW5kLiBU byBzcGVlZCB0aGlzDQohIAkgKiB1cCwgd2UgY291bGQgcmVtZW1iZXIgdGhl IGFjdHVhbCBlbmQgb2YgdGhlIHF1ZXVlIGF0IEVuZFF1ZXJ5IGFuZA0KISAJ ICogZXhhbWluZSBvbmx5IGV2ZW50cyB0aGF0IGFyZSBuZXdlci4gT24gc3Rh dGUgY2hhbmdlcyB3ZSBzaW1wbHkNCiEgCSAqIHJlc2V0IHRoZSBzYXZlZCBw b3NpdGlvbiB0byB0aGUgYmVnaW5uaW5nIG9mIHRoZSBxdWV1ZSBhbmQgcHJv Y2Vzcw0KISAJICogYWxsIGV2ZW50cyBvbmNlIHdpdGggdGhlIG5ldyBzdGF0 ZXMuDQogIAkgKi8NCiAgDQogIAkvKiBNYWtlIGEgcGVyLXR1cGxlIG1lbW9y eSBjb250ZXh0IGZvciB0cmlnZ2VyIGZ1bmN0aW9uIGNhbGxzICovDQogIAlw ZXJfdHVwbGVfY29udGV4dCA9DQogIAkJQWxsb2NTZXRDb250ZXh0Q3JlYXRl KEN1cnJlbnRNZW1vcnlDb250ZXh0LA0KISAJCQkJCQkJICAiRGVmZXJyZWRU cmlnZ2VyVHVwbGVDb250ZXh0IiwNCiEgCQkJCQkJCSAgQUxMT0NTRVRfREVG QVVMVF9NSU5TSVpFLA0KISAJCQkJCQkJICBBTExPQ1NFVF9ERUZBVUxUX0lO SVRTSVpFLA0KISAJCQkJCQkJICBBTExPQ1NFVF9ERUZBVUxUX01BWFNJWkUp Ow0KICANCi0gCWV2ZW50ID0gZGVmdHJpZ19ldmVudHM7DQogIAl3aGlsZSAo ZXZlbnQgIT0gTlVMTCkNCiAgCXsNCiAgCQlib29sCQlzdGlsbF9kZWZlcnJl ZF9vbmVzID0gZmFsc2U7DQotLS0gMTg2MywxODk0IC0tLS0NCiAgCSAqIGFy ZSBnb2luZyB0byBkaXNjYXJkIHRoZSB3aG9sZSBldmVudCBxdWV1ZSBvbiBy ZXR1cm4gYW55d2F5LCBzbyBubw0KICAJICogbmVlZCB0byBib3RoZXIgd2l0 aCAicmV0YWlsIiBwZnJlZSdzLg0KICAJICoNCiEgCSAqIEluIGltbWVkaWF0 ZV9vbmx5IGlzIHRydWUsIHdlIG9ubHkgY2hlY2sgZnJvbSB0aGUgZW5kIG9m IHRoZSBxdWV1ZQ0KISAJICogYXQgdGhlIHByZXZpb3VzIEludm9rZUV2ZW50 cyBhbmQgZXhhbWluZSBuZXdlciBldmVudHMuIE9uIHN0YXRlIA0KISAJICog Y2hhbmdlcyB3ZSBzaW1wbHkgcmVzZXQgdGhlIHNhdmVkIHBvc2l0aW9uIHRv IHRoZSBiZWdpbm5pbmcgb2YgDQohIAkgKiB0aGUgcXVldWUgYW5kIHByb2Nl c3MgYWxsIGV2ZW50cyBvbmNlIHdpdGggdGhlIG5ldyBzdGF0ZXMuDQogIAkg Ki8NCiAgDQogIAkvKiBNYWtlIGEgcGVyLXR1cGxlIG1lbW9yeSBjb250ZXh0 IGZvciB0cmlnZ2VyIGZ1bmN0aW9uIGNhbGxzICovDQogIAlwZXJfdHVwbGVf Y29udGV4dCA9DQogIAkJQWxsb2NTZXRDb250ZXh0Q3JlYXRlKEN1cnJlbnRN ZW1vcnlDb250ZXh0LA0KISAJCQkgICJEZWZlcnJlZFRyaWdnZXJUdXBsZUNv bnRleHQiLA0KISAJCQkgIEFMTE9DU0VUX0RFRkFVTFRfTUlOU0laRSwNCiEg CQkJICBBTExPQ1NFVF9ERUZBVUxUX0lOSVRTSVpFLA0KISAJCQkgIEFMTE9D U0VUX0RFRkFVTFRfTUFYU0laRSk7DQohIA0KISAJLyoNCiEgCSAqIElmIGlt bWVkaWF0ZV9vbmx5IGlzIHRydWUsIHRoZW4gdGhlIG9ubHkgZXZlbnRzIHRo YXQgY291bGQgaGF2ZSBmaXJlZA0KISAJICogYXJlIHRob3NlIHNpbmNlIGRl ZnRyaWdfZXZlbnRzX2ltbS4gIA0KISAJICogVGhlIG9uZSBleGNlcHRpb24g dG8gb25seSBzaW5jZSBkZWZ0cmlnX2V2ZW50c19pbW0gd291bGQgYmUgDQoh IAkgKiBTRVQgQ09OU1RSQUlOVFMgLi4uIElNTUVESUFURSBzbyB3ZSBzZXQg aXQgdG8gTlVMTCBpbiB0aGVyZQ0KISAJICogYW5kIHRyZWF0IE5VTEwgYXMg YmVpbmcgZXF1aXZhbGVudCB0byB0aGUgZW50aXJlIGxpc3QuDQohIAkgKi8N CiEgCWlmIChpbW1lZGlhdGVfb25seSkgDQohIAkJZXZlbnQgPSBkZWZ0cmln X2V2ZW50c19pbW07DQohIAlpZiAoZXZlbnQgPT0gTlVMTCkNCiEgCQlldmVu dCA9IGRlZnRyaWdfZXZlbnRzOw0KICANCiAgCXdoaWxlIChldmVudCAhPSBO VUxMKQ0KICAJew0KICAJCWJvb2wJCXN0aWxsX2RlZmVycmVkX29uZXMgPSBm YWxzZTsNCioqKioqKioqKioqKioqKg0KKioqIDE5OTMsMjAwNCAqKioqDQot LS0gMjAwNywyMDIyIC0tLS0NCiAgCS8qIFVwZGF0ZSBsaXN0IHRhaWwgcG9p bnRlciBpbiBjYXNlIHdlIGp1c3QgZGVsZXRlZCB0YWlsIGV2ZW50ICovDQog IAlkZWZ0cmlnX2V2ZW50X3RhaWwgPSBwcmV2X2V2ZW50Ow0KICANCisgCS8q IFNldCB0aGUgaW1tZWRpYXRlIGV2ZW50IHBvaW50ZXIgdG8gdGhlIHRhaWwg Ki8NCisgCWRlZnRyaWdfZXZlbnRzX2ltbSA9IHByZXZfZXZlbnQ7DQorIA0K ICAJLyogUmVsZWFzZSB3b3JraW5nIHJlc291cmNlcyAqLw0KICAJaWYgKHJl bCkNCiAgCQloZWFwX2Nsb3NlKHJlbCwgTm9Mb2NrKTsNCiAgCUZyZWVUcmln Z2VyRGVzYyh0cmlnZGVzYyk7DQogIAlpZiAoZmluZm8pDQogIAkJcGZyZWUo ZmluZm8pOw0KKyANCiAgCU1lbW9yeUNvbnRleHREZWxldGUocGVyX3R1cGxl X2NvbnRleHQpOw0KICB9DQogIA0KKioqKioqKioqKioqKioqDQoqKiogMjI3 MiwyMjc3ICoqKioNCi0tLSAyMjkwLDIzMDMgLS0tLQ0KICANCiAgCQlNZW1v cnlDb250ZXh0U3dpdGNoVG8ob2xkY3h0KTsNCiAgCX0NCisgDQorIAkvKg0K KyAJICogUmVzZXQgdGhlIHBvaW50ZXIgZm9yIHRoZSBpbW1lZGlhdGUgY29u c3RyYWludHMgdG8gTlVMTCAoaWUNCisgCSAqIHVzZSBiZWdpbm5pbmcgb2Yg bGlzdCkuICBUaGlzIGlzIHJlYWxseSBvbmx5IG5lY2Vzc2FyeSBmb3INCisg CSAqIGRlYWxpbmcgd2hlbiBzZXR0aW5nIHRvIElNTUVESUFURSwgYW5kIGNv dWxkIHJlYWxseSBwb2ludA0KKyAJICogdGhlIGZpcnN0IGNvbnN0cmFpbnQg d2UgY2hhbmdlZCwgYnV0IGZvciBub3cgdGhpcyB3aWxsIGRvLg0KKyAJICov DQorIAlkZWZ0cmlnX2V2ZW50c19pbW0gPSBOVUxMOw0KICANCiAgCS8qDQog IAkgKiBTUUw5OSByZXF1aXJlcyB0aGF0IHdoZW4gYSBjb25zdHJhaW50IGlz IHNldCB0byBJTU1FRElBVEUsIGFueQ0K --0-176117628-1050854650=:28973--