X-Original-To: pgsql-hackers@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id 9C802475A80 for ; Sun, 20 Apr 2003 20:09:31 -0400 (EDT) Received: from filer (12-234-86-219.client.attbi.com [12.234.86.219]) by postgresql.org (Postfix) with ESMTP id DE3D147580B for ; Sun, 20 Apr 2003 20:09:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) (uid 1000) by filer with local; Sun, 20 Apr 2003 17:09:34 -0700 Date: Sun, 20 Apr 2003 17:09:34 -0700 From: Kevin Brown To: pgsql-hackers@postgresql.org Subject: Re: [PERFORM] Foreign key performance Message-ID: <20030421000933.GP1833@filer> Mail-Followup-To: Kevin Brown , pgsql-hackers@postgresql.org References: <20030420090304.F28973-200000@megazone23.bigpanda.com> <6996.1050858564@sss.pgh.pa.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <6996.1050858564@sss.pgh.pa.us> User-Agent: Mutt/1.4i Organization: Frobozzco International X-Spam-Status: No, hits=-38.0 required=5.0 tests=BAYES_10,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-Archive-Number: 200304/730 X-Sequence-Number: 38220 Tom Lane wrote: > Stephan Szabo writes: > > Okay, this changes the second paragraph of that comment. I left in the > > comment that's really similar next to where I actually do the selection of > > which start point to use. > > This had a bit of a problem yet: the loop in deferredTriggerInvokeEvents > expects 'prev_event' to point to the list entry just before 'event'. > A nice byproduct of fixing that is we don't uselessly rescan the last list > entry. I also tried to improve the comments a little. You can see what > I actually applied at > > http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/trigger.c Any chance of backporting these changes to 7_3_STABLE (when you're satisfied they don't break anything)? Just looking at the CVS log for trigger.c, it appears there have been enough changes since then that it might not be easy to do (and since it's not necessarily a "bug fix" as such, it might not qualify for backporting to a stable version). Even if it's not something that can be put into another release of 7.3, it would certainly be useful to me. It might be useful to enough people to justify releasing it as a patch on -patches, if nothing else. I'd do it myself but I don't understand the trigger code at all (and if there's any documentation you can point me to that describes the various functions and supporting data structures in trigger.c, that would help a lot), and I'd rather not touch something like that until I understand it thoroughly. -- Kevin Brown kevin@sysexperts.com