X-Original-To: pgsql-hackers@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id EAF68475E14 for ; Tue, 22 Apr 2003 07:44:58 -0400 (EDT) Received: from filer (12-234-86-219.client.attbi.com [12.234.86.219]) by postgresql.org (Postfix) with ESMTP id 2E50C474E42 for ; Tue, 22 Apr 2003 07:44:27 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) (uid 1000) by filer with local; Tue, 22 Apr 2003 04:44:30 -0700 Date: Tue, 22 Apr 2003 04:44:30 -0700 From: Kevin Brown To: pgsql-hackers@postgresql.org Subject: Re: [PERFORM] Foreign key performance Message-ID: <20030422114429.GQ1833@filer> Mail-Followup-To: Kevin Brown , pgsql-hackers@postgresql.org References: <20030420090304.F28973-200000@megazone23.bigpanda.com> <6996.1050858564@sss.pgh.pa.us> <20030421000933.GP1833@filer> <21359.1050885300@sss.pgh.pa.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <21359.1050885300@sss.pgh.pa.us> User-Agent: Mutt/1.4i Organization: Frobozzco International X-Spam-Status: No, hits=-38.0 required=5.0 tests=BAYES_10,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-Archive-Number: 200304/774 X-Sequence-Number: 38264 Tom Lane wrote: > Kevin Brown writes: > > Any chance of backporting these changes to 7_3_STABLE (when you're > > satisfied they don't break anything)? Just looking at the CVS log for > > trigger.c, it appears there have been enough changes since then that > > it might not be easy to do (and since it's not necessarily a "bug fix" > > as such, it might not qualify for backporting to a stable version). > > I'd be pretty hesitant to make such a change in the stable branch --- > at least not without a lot of testing. If you and others want to > provide such testing, go to it. The patch appears to apply cleanly > enough to 7.3, but here's an adjusted patch if fuzz makes you > nervous... Thanks, Tom. I've applied the patch to my server and it has so far passed the few tests I've thrown at it so far (it has detected foreign key violations in both immediate and deferred trigger mode). And just so you know, it performs FAR better than the pre-patched version does -- in the overall transaction I'm doing, I see very little difference now between deferred triggers and no triggers! -- Kevin Brown kevin@sysexperts.com