Date: Fri, 4 Nov 2005 10:14:31 -0800
From: David Fetter <david@fetter.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Merlin Moncure <merlin.moncure@rcsonline.com>,
	pgsql-performance@postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] insert performance for win32
Message-ID: <20051104181431.GA4017@fetter.org>
References: <6EE64EF3AB31D5448D0007DD34EEB3417DD7D3@Herge.rcsinc.local>
	<15926.1131127280@sss.pgh.pa.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <15926.1131127280@sss.pgh.pa.us>
User-Agent: Mutt/1.4.2.1i

On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote:
> "Merlin Moncure" <merlin.moncure@rcsonline.com> writes:
> > Nailed it.
> 
> > problem is in mainloop.c -> setup_cancel_handler.  Apparently you
> > can have multiple handlers and windows keeps track of them all,
> > even if they do the same thing.  Keeping track of so many system
> > handles would naturally slow the whole process down.
> 
> Yipes.  So we really want to do that only once.
> 
> AFAICS it is appropriate to move the sigsetjmp and
> setup_cancel_handler calls in front of the per-line loop inside
> MainLoop --- can anyone see a reason not to?
> 
> I'm inclined to treat this as an outright bug, not just a minor
> performance issue, because it implies that a sufficiently long psql
> script would probably crash a Windows machine.

Ouch.  In light of this, are we *sure* what we've got a is a candidate
for release?

Cheers,
D
-- 
David Fetter david@fetter.org http://fetter.org/
phone: +1 510 893 6100   mobile: +1 415 235 3778

Remember to vote!