From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200511041821.jA4IL7117478@candle.pha.pa.us>
Subject: Re: [HACKERS] insert performance for win32
In-Reply-To: <20051104181431.GA4017@fetter.org>
To: David Fetter <david@fetter.org>
Date: Fri, 4 Nov 2005 13:21:07 -0500 (EST)
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Merlin Moncure <merlin.moncure@rcsonline.com>,
	pgsql-performance@postgresql.org, pgsql-hackers@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII

David Fetter wrote:
> On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote:
> > "Merlin Moncure" <merlin.moncure@rcsonline.com> writes:
> > > Nailed it.
> > 
> > > problem is in mainloop.c -> setup_cancel_handler.  Apparently you
> > > can have multiple handlers and windows keeps track of them all,
> > > even if they do the same thing.  Keeping track of so many system
> > > handles would naturally slow the whole process down.
> > 
> > Yipes.  So we really want to do that only once.
> > 
> > AFAICS it is appropriate to move the sigsetjmp and
> > setup_cancel_handler calls in front of the per-line loop inside
> > MainLoop --- can anyone see a reason not to?
> > 
> > I'm inclined to treat this as an outright bug, not just a minor
> > performance issue, because it implies that a sufficiently long psql
> > script would probably crash a Windows machine.
> 
> Ouch.  In light of this, are we *sure* what we've got a is a candidate
> for release?

Good point.  It is something we would fix in a minor release, so it
doesn't seem worth doing another RC just for that.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073