Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id F300E633B20; Mon, 8 Feb 2010 15:30:19 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 60037-06-2; Mon, 8 Feb 2010 19:30:09 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.anarazel.de (mail.anarazel.de [217.115.131.40]) by mail.postgresql.org (Postfix) with ESMTP id D5A36633455; Mon, 8 Feb 2010 15:30:00 -0400 (AST) Received: from alap2.localnet (e178234008.adsl.alicedsl.de [85.178.234.8]) by mail.anarazel.de (Postfix) with ESMTPSA id 977E9448004; Mon, 8 Feb 2010 20:29:56 +0100 (CET) From: Andres Freund To: Greg Stark Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) Date: Mon, 8 Feb 2010 20:29:46 +0100 User-Agent: KMail/1.13.0 (Linux/2.6.33-rc5-andres-00243-g6ea299e; KDE/4.3.98; x86_64; ; ) Cc: Robert Haas , Alvaro Herrera , pgsql-hackers@postgresql.org, Tom Lane , Greg Smith , pgsql-performance@postgresql.org, Michael Clemmons , Hannu Krosing , Scott Marlowe References: <4427a97a0912101235x3ade510blcc00d5ce9883c6b6@mail.gmail.com> <603c8f071002072053w16897addtd52fcc4cf880df53@mail.gmail.com> <407d949e1002081034n3dd82addw2b93d35db042042c@mail.gmail.com> In-Reply-To: <407d949e1002081034n3dd82addw2b93d35db042042c@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002082029.55041.andres@anarazel.de> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-0.74 tagged_above=-10 required=5 tests=BAYES_20=-0.74 X-Spam-Level: X-Archive-Number: 201002/125 X-Sequence-Number: 37546 On Monday 08 February 2010 19:34:01 Greg Stark wrote: > On Mon, Feb 8, 2010 at 4:53 AM, Robert Haas wrote: > > On Sun, Feb 7, 2010 at 10:09 PM, Alvaro Herrera > > > >> Yeah, it seems there are two patches here -- one is the addition of > >> fsync_fname() and the other is the fsync_prepare stuff. > > Sorry, I'm just catching up on my mail from FOSDEM this past weekend. > > I had come to the same conclusion as Greg that I might as well just > commit it with Tom's "pg_flush_data()" name and we can decide later if > and when we have pg_fsync_start()/pg_fsync_finish() whether it's worth > keeping two apis or not. > > So I was just going to commit it like that but I discovered last week > that I don't have cvs write access set up yet. I'll commit it as soon > as I generate a new ssh key and Dave installs it, etc. I intentionally > picked a small simple patch that nobody was waiting on because I knew > there was a risk of delays like this and the paperwork. I'm nearly > there. Do you still want me to split the patches into two or do you want to do it yourself? One in multiple versions for the directory fsync and another one for 9.0? Andres