Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id 0910D11DF225; Thu, 31 May 2012 12:01:10 -0300 (ADT) Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Sa6s9-0008OL-RY; Thu, 31 May 2012 15:01:10 +0000 Received: from bruce by momjian.us with local (Exim 4.72) (envelope-from ) id 1Sa6ru-0005BS-Nz; Thu, 31 May 2012 11:00:54 -0400 Date: Thu, 31 May 2012 11:00:54 -0400 From: Bruce Momjian To: Tom Lane Cc: Robert Haas , Claudio Freire , Robert Klemme , Tatsuo Ishii , pgsql-performance@postgresql.org, pgsql-hackers@postgresql.org Subject: Re: [HACKERS] pg_dump and thousands of schemas Message-ID: <20120531150054.GF26894@momjian.us> References: <20120529.185149.1127748531209576379.t-ishii@sraoss.co.jp> <20120531.174526.2183902405630094684.t-ishii@sraoss.co.jp> <20120531.230757.2014494683420217075.t-ishii@sraoss.co.jp> <9787.1338474676@sss.pgh.pa.us> <10443.1338475851@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10443.1338475851@sss.pgh.pa.us> User-Agent: Mutt/1.5.20 (2009-06-14) X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201205/190 X-Sequence-Number: 47014 On Thu, May 31, 2012 at 10:50:51AM -0400, Tom Lane wrote: > Robert Haas writes: > > On Thu, May 31, 2012 at 10:31 AM, Tom Lane wrote: > >> I'm not; Jeff Janes is.  But you shouldn't be holding your breath > >> anyway, since it's 9.3 material at this point. > > > I agree we can't back-patch that change, but then I think we ought to > > consider back-patching some variant of Tatsuo's patch. Maybe it's not > > reasonable to thunk an arbitrary number of relation names in there on > > one line, but how about 1000 relations per LOCK statement or so? I > > guess we'd need to see how much that erodes the benefit, but we've > > certainly done back-branch rearrangements in pg_dump in the past to > > fix various kinds of issues, and this is pretty non-invasive. > > I am not convinced either that this patch will still be useful after > Jeff's fix goes in, or that it provides any meaningful savings when > you consider a complete pg_dump run. Yeah, it will make the lock > acquisition phase faster, but that's not a big part of the runtime > except in very limited scenarios (--schema-only, perhaps). FYI, that is the pg_upgrade use-case, and pg_dump/restore time is reportedly taking the majority of time in many cases. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +