X-Original-To: pgsql-performance-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id A9E72D1D43B for ; Sun, 7 Mar 2004 03:47:01 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 84614-05 for ; Sat, 6 Mar 2004 23:47:04 -0400 (AST) Received: from sss.pgh.pa.us (unknown [192.204.191.242]) by svr1.postgresql.org (Postfix) with ESMTP id B5CF3D1D400 for ; Sat, 6 Mar 2004 23:46:59 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i273kv9X020142; Sat, 6 Mar 2004 22:46:57 -0500 (EST) To: Larry Rosenman Cc: John Siracusa , Postgres Performance Subject: Re: Feature request: smarter use of conditional indexes In-reply-to: <32080000.1078627178@lerlaptop.lerctr.org> References: <41C473B6-6FDF-11D8-9156-000A95BA4506@mindspring.com> <32080000.1078627178@lerlaptop.lerctr.org> Comments: In-reply-to Larry Rosenman message dated "Sat, 06 Mar 2004 20:39:38 -0600" Date: Sat, 06 Mar 2004 22:46:57 -0500 Message-ID: <20141.1078631217@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/85 X-Sequence-Number: 5941 Larry Rosenman writes: > Just a suggestion, please use diff -c format, as it makes it easier for > the folks who apply the patches to do so. That's not just a suggestion ... patches that aren't in diff -c (or at least diff -u) format will be rejected out of hand. Without the context lines provided by these formats, applying a patch is an exercise in risk-taking, because you can't be certain that you are applying the same patch the submitter intended. Personally I consider -c format the only one of the three that is readable for reviewing purposes, so even if I weren't intending immediate application, I'd ask for -c before looking at the patch. There are some folks who consider -u format readable, but I'm not one of them ... BTW, patches really ought to go to pgsql-patches ... they're a bit off-topic here. regards, tom lane