Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVgZP-0002nG-C1 for pgsql-performance@arkaria.postgresql.org; Mon, 23 Jan 2017 15:30:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cVgZO-00083z-VG for pgsql-performance@arkaria.postgresql.org; Mon, 23 Jan 2017 15:30:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cVgXi-0004Xe-Jg for pgsql-performance@postgresql.org; Mon, 23 Jan 2017 15:28:26 +0000 Received: from tamriel.snowman.net ([72.66.115.51]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVgXe-0000mR-SS for pgsql-performance@postgresql.org; Mon, 23 Jan 2017 15:28:25 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 37CED5F796; Mon, 23 Jan 2017 10:27:22 -0500 (EST) Date: Mon, 23 Jan 2017 10:27:22 -0500 From: Stephen Frost To: Jim Nasby Cc: Vladimir Borodin , Pavel Stehule , Dinesh Chandra 12108 , "Madusudanan.B.N" , "pgsql-performance@postgresql.org" , David Steele Subject: Re: Backup taking long time !!! Message-ID: <20170123152722.GX18360@tamriel.snowman.net> References: <23dc5b1ea9604ec3afdaabdd15491085@cyient.com> <20170120122224.GF18360@tamriel.snowman.net> <20170120134054.GH18360@tamriel.snowman.net> <7696A57C-C871-4A45-9141-FFD5F75CCB65@simply.name> <20170120150646.GP18360@tamriel.snowman.net> <68f87a97-15c2-5e4e-5730-77f9af2ca165@BlueTreble.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="86WxJERi0+zGM57f" Content-Disposition: inline In-Reply-To: <68f87a97-15c2-5e4e-5730-77f9af2ca165@BlueTreble.com> X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-91-generic (x86_64) X-Uptime: 10:25:23 up 198 days, 16:49, 5 users, load average: 0.24, 0.14, 0.09 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -5.1 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-performance Precedence: bulk Sender: pgsql-performance-owner@postgresql.org --86WxJERi0+zGM57f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Jim Nasby (Jim.Nasby@BlueTreble.com) wrote: > On 1/20/17 9:06 AM, Stephen Frost wrote: > >All the pages are the same size, so I'm surprised you didn't consider > >just having a format along the lines of: magic+offset+page, > >magic+offset+page, magic+offset+page, etc... >=20 > Keep in mind that if you go that route you need to accommodate BLKSZ > <> 8192. If you want my 2c on that, running with BLKSZ <> 8192 is playing with fire, or at least running with scissors. That said, yes, the code should either barf when BLKSZ <> 8192 in a very clear way early on, or handle it correctly, and be tested with such configurations. Thanks! Stephen --86WxJERi0+zGM57f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJYhiDZAAoJEO1sijiDR2RVKJYQAL6sMjm593bmuTKjrtl7scky MRALDoxxV8LrZ2duozX+XIuqy2iPqaRdP3A9WgtO7BtihJjJcih5NS7ss4FK1kjA MLnkTYhf69v3Lo+ULAxiG7TrCanIf1rGwLr99iWOwTxN7wtENNWWqbnlr6OUHf0u Ev+JBfVHRWifc1/Ye3xD9WTljk6C6pTFPtpoLBBZevKJfAL/jl9dK5W+PQKOpLZV HlNrsHJYOLAJ11ddY1eSXTFLeCGaY24IPXVFvW6FbkECLZevQukw5epPuQYhsIv4 j7S6CPCWQLochPl1Z+LQd9r//EojJAR6Kuaa3eEO2IIiwoTbPqoewD4CTdlktg6s SUniX8fws2naAVGyhM+G+sIBBqwJpt1jiefqLahrMJFjRS8vCmzcGl1zyxOob8+9 xMnsM0ZNtkCdyPt8tSap26f8goJqq+VQwpwiefFzxiEDqT5umwxgiRb11wdJNJQr 1NS0WsrjPJTYjZv56+cATK1JeaALhLYiqWlP7sxArbI+xXOa0LlpMuZfAoZATMax z/JMULPGIFLKiacB1jvXc8hilWIRORjeEWlhgPyXZvPffuKxin4cR62MY8IjqAQd 89a8T+fXO/45S1u+nt30No2DtYdT9NzB91eVsUofOPjZCSVolqOzb8WMSw5i7Bly 0IOT8aq/JTYx9o6cIfmo =3uT+ -----END PGP SIGNATURE----- --86WxJERi0+zGM57f--