Date: Fri, 20 Jul 2018 09:45:10 -0700
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alex Tokarev <dwalin@dwalin.ru>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	pgsql-performance@postgresql.org
Subject: Re: Faster str to int conversion (was Table with large number of int
 columns, very slow COPY FROM)
Message-ID: <20180720164510.dvexjhtutylozmhj@alap3.anarazel.de>
References: <D64F5359.2993D%dwalin@dwalin.ru>
 <20171208181734.db7gk22mtq7i44ax@alap3.anarazel.de>
 <20171208214437.qgn6zdltyq5hmjpk@alap3.anarazel.de>
 <20180707200158.wpqkd7rjr4jxq5g7@alap3.anarazel.de>
 <CA+TgmoZzSV4p+HAwm42VcEcL=WQQ7su1g1yox7VhFvfJz2AFzw@mail.gmail.com>
 <20180719203212.qso3vgljwns75oho@alap3.anarazel.de>
 <CA+TgmoY+e-yid5CZDh3HmSm9FEXWXsX_s5ANqYFrjgRmyV4QAA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoY+e-yid5CZDh3HmSm9FEXWXsX_s5ANqYFrjgRmyV4QAA@mail.gmail.com>
Precedence: bulk

Hi,

On 2018-07-20 08:27:34 -0400, Robert Haas wrote:
> On Thu, Jul 19, 2018 at 4:32 PM, Andres Freund <andres@anarazel.de> wrote:
> >> 1. Why the error message changes?  If there's a good reason, it should
> >> be done as a separate commit, or at least well-documented in the
> >> commit message.
> >
> > Because there's a lot of "invalid input syntax for type %s: \"%s\"",
> > error messages, and we shouldn't force translators to have separate
> > version that inlines the first %s.  But you're right, it'd be worthwhile
> > to point that out in the commit message.
> 
> It just seems weird that they're bundled together in one commit like this.

I'll push it separately.

> Nothing else from me...

Thanks for looking!

Greetings,

Andres Freund