Date: Thu, 7 Oct 2021 22:38:49 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Jeremy Schneider <schneider@ardentperf.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Jeff Holt <jeff.holt@method-r.com>,
	pgsql-performance@lists.postgresql.org,
	Laurenz Albe <laurenz.albe@cybertec.at>
Subject: Re: Better, consistent instrumentation for postgreSQL using a
 similar API as Oracle
Message-ID: <20211008023849.GF5476@momjian.us>
References: 
 <CAMzkAgGAwh=vsUmtEOC-57GhbFo4eh_B7gJCWMqH4yR7hHJjgA@mail.gmail.com>
 <CAH2-Wzn-+=aYrMw4pHbV7yYVyRYskJkNLaV6HeHj94oyKJiRKA@mail.gmail.com>
 <efbd4d1a-48d5-99ac-549f-5e3f37812273@ardentperf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <efbd4d1a-48d5-99ac-549f-5e3f37812273@ardentperf.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20211008023849.GF5476%40momjian.us>
Precedence: bulk

On Thu, Oct  7, 2021 at 07:15:39PM -0700, Jeremy Schneider wrote:
> PostgreSQL added wait events starting in 9.6 and the last thing that's
> missing is an integrated way to trace or log them. A simple starting
> point could be a session-level GUC that enables a hook in
> pgstat_report_wait_start() and pgstat_report_wait_end() to just drop
> messages in the log. These log messages could then easily be processed
> to generate the similar profiles to the ones we used with other
> databases. Basically I agree 100% with Jeff that while you can do these
> things with perf probes or eBPF, there are massive advantages to having
> it baked in the database. With the right tools, this makes session
> profiling available to regular users (who do their day jobs with excel
> rather than eBPF).

Our wait events reported in pg_stat_activity are really only a first
step --- I always felt it needed an external tool to efficiently collect
and report those wait events.  I don't think the server log is the right
place to collect them.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.