Feedback-ID: id4a34324:Fastmail
Date: Mon, 17 Jul 2023 08:34:32 -0700
From: Andres Freund <andres@anarazel.de>
To: Dimitrios Apostolou <jimis@gmx.net>
Cc: Thomas Munro <thomas.munro@gmail.com>, pgsql-performance@postgresql.org
Subject: Re: Performance implications of 8K pread()s
Message-ID: <20230717153432.5qm6ywcdhhl5m2ny@awork3.anarazel.de>
References: <218fa2e0-bc58-e469-35dd-c5cb35906064@gmx.net>
 <CA+hUKG+Zr8FBi3pojzU3x4k5XyenHhZ_mdWQ7pKwGeFT2+Tq+Q@mail.gmail.com>
 <b676deee-9938-d11b-c9d9-2373f04baa45@gmx.net>
 <CA+hUKG+EA-nfLKV5EF-P3PBTKuj03Bt58Gs8osvjqp13+JnSYg@mail.gmail.com>
 <e60b5efc-c861-a00f-e1a1-c0efece49ada@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e60b5efc-c861-a00f-e1a1-c0efece49ada@gmx.net>
Archived-At: 
 <https://www.postgresql.org/message-id/20230717153432.5qm6ywcdhhl5m2ny%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-07-17 16:42:31 +0200, Dimitrios Apostolou wrote:
> Thanks, it sounds promising! Are the changes in the 16 branch already,
> i.e. is it enough to fetch sources for 16-beta2?

No, this is in a separate branch.

https://github.com/anarazel/postgres/tree/aio


> If so do I just configure --with-liburing (I'm on linux) and run with
> io_method=io_uring?

It's probably worth trying out both io_uring and worker. I've not looked at
performance on btrfs. I know that some of the optimized paths for io_uring
(being able to perform filesystem IO without doing so synchronously in an
in-kernel thread) require filesystem cooperation, and I do not know how much
attention btrfs has received for that.


> Else, if I use the io_method=worker what is a sensible amount of worker
> threads?

Depends on your workload :/. If you just want to measure whether it fixes your
single-threaded query execution issue, the default should be just fine.


> Should I also set all the flags for direct I/O?  (io_data_direct=on
> io_wal_direct=on).

FWIW, I just pushed a rebased version to the aio branch, and there the config
for direct io is
io_direct = 'data, wal, wal_init'
(or a subset thereof).