Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id BAAA12E0053 for ; Thu, 27 Mar 2008 18:11:45 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 27842-02 for ; Thu, 27 Mar 2008 18:11:38 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 7FDCC2E0057 for ; Thu, 27 Mar 2008 18:11:38 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m2RLBbuV002093; Thu, 27 Mar 2008 17:11:37 -0400 (EDT) To: Robert Treat cc: pgsql-hackers@postgresql.org Subject: Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search In-reply-to: <200803271656.45574.xzilla@users.sourceforge.net> References: <20080317021856.0D2D37558DC@cvs.postgresql.org> <200803271656.45574.xzilla@users.sourceforge.net> Comments: In-reply-to Robert Treat message dated "Thu, 27 Mar 2008 16:56:45 -0400" Date: Thu, 27 Mar 2008 17:11:37 -0400 Message-ID: <2092.1206652297@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200803/1132 X-Sequence-Number: 115933 Robert Treat writes: > On Sunday 16 March 2008 22:18, Tom Lane wrote: >> Fix TransactionIdIsCurrentTransactionId() to use binary search instead of >> linear search when checking child-transaction XIDs. > Are there any plans to backpatch this into REL8_3_STABLE? No. > It looks like I am > hitting a pretty serious performance regression on 8.3 with a stored > procedure that grabs a pretty big recordset, and loops through doing > insert....update on unique failures. The procedure get progressivly slower > the more records involved... and dbx shows me stuck in > TransactionIdIsCurrentTransactionId(). If you can convince me it's a regression I might reconsider, but I rather doubt that 8.2 was better, regards, tom lane