Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfPzQ-00078O-Nm for pgsql-hackers@arkaria.postgresql.org; Sat, 08 May 2021 16:39:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lfPzO-0001bp-H6 for pgsql-hackers@arkaria.postgresql.org; Sat, 08 May 2021 16:39:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfPzO-0001b5-9O for pgsql-hackers@lists.postgresql.org; Sat, 08 May 2021 16:39:38 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfPzM-00026n-Ct for pgsql-hackers@lists.postgresql.org; Sat, 08 May 2021 16:39:37 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 148GdXPs239284; Sat, 8 May 2021 12:39:33 -0400 From: Tom Lane To: Justin Pryzby cc: Michael Paquier , Bruce Momjian , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] force_parallel_mode and GUC categories In-reply-to: <20210429042404.GG27406@telsasoft.com> References: <20210403141651.GI6592@telsasoft.com> <20210403151201.GD29125@momjian.us> <3972636.1617464359@sss.pgh.pa.us> <20210403154114.GJ6592@telsasoft.com> <20210403154336.GG29125@momjian.us> <20210404012546.GK6592@telsasoft.com> <20210429042404.GG27406@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Wed, 28 Apr 2021 23:24:04 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <239282.1620491973.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 08 May 2021 12:39:33 -0400 Message-ID: <239283.1620491973@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > ...but, I realized just now that *zero* other GUCs use "REPLICATION". > And the documentation puts it in 20.6.1. Sending Servers, > so it still seems to me that this is correct to move this, too. > https://www.postgresql.org/docs/devel/runtime-config-replication.html > Then, I wonder if REPLICATION should be removed from guc_tables.h... For the archives' sake --- these things are now committed as part of a55a98477. I'd forgotten this thread, and then rediscovered the same inconsistencies as Justin had while reviewing Bharath Rupireddy's patch for bug #16997 [1]. I think this thread can now be closed off as done. However, there are some open issues mentioned in the other thread, if anyone here wants to comment. regards, tom lane [1] https://www.postgresql.org/message-id/flat/16997-ff16127f6e0d1390%40po= stgresql.org