Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 8FA18632D25
	for <pgsql-performance-postgresql.org@mail.postgresql.org>;
	Sun,  7 Feb 2010 12:24:22 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024) with ESMTP id 24106-07
	for <pgsql-performance-postgresql.org@mail.postgresql.org>;
	Sun,  7 Feb 2010 16:24:03 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id E15A8632C8A
	for <pgsql-performance@postgresql.org>;
	Sun,  7 Feb 2010 12:24:11 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id o17GO0NZ024185;
	Sun, 7 Feb 2010 11:24:00 -0500 (EST)
To: Greg Smith <greg@2ndquadrant.com>
cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	Greg Stark <gsstark@mit.edu>, pgsql-hackers@postgresql.org,
	pgsql-performance@postgresql.org,
	Michael Clemmons <glassresistor@gmail.com>,
	Hannu Krosing <hannu@2ndquadrant.com>,
	Scott Marlowe <scott.marlowe@gmail.com>
Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1
	ubuntu karmic slow createdb)
In-reply-to: <4B6E8682.7030006@2ndquadrant.com> 
References: <4427a97a0912101235x3ade510blcc00d5ce9883c6b6@mail.gmail.com>
	<4B698605.50506@anarazel.de> <4B6CF822.9010608@2ndquadrant.com>
	<201002061304.01682.andres@anarazel.de>
	<603c8f071002062113k262dd8xcd0cdd482d2c6150@mail.gmail.com>
	<4B6E8682.7030006@2ndquadrant.com>
Comments: In-reply-to Greg Smith <greg@2ndquadrant.com>
	message dated "Sun, 07 Feb 2010 04:23:14 -0500"
Date: Sun, 07 Feb 2010 11:24:00 -0500
Message-ID: <24184.1265559840@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.465 tagged_above=-10 required=5 tests=AWL=0.134,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 201002/110
X-Sequence-Number: 37531

Greg Smith <greg@2ndquadrant.com> writes:
> This is turning into yet another one of those situations where something 
> simple and useful is being killed by trying to generalize it way more 
> than it needs to be, given its current goals and its lack of external 
> interfaces.  There's no catversion bump or API breakage to hinder future 
> refactoring if this isn't optimally designed internally from day one.

I agree that it's too late in the cycle for any major redesign of the
patch.  But is it too much to ask to use a less confusing name for the
function?

			regards, tom lane