X-Original-To: pgsql-performance-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 4B4D452AA2 for ; Mon, 14 Mar 2005 19:30:58 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 33181-03 for ; Mon, 14 Mar 2005 19:30:49 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 09BA452A5B for ; Mon, 14 Mar 2005 19:30:48 +0000 (GMT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id j2EJUdvQ029102; Mon, 14 Mar 2005 14:30:39 -0500 (EST) To: Jan Wieck Cc: Robert Treat , Christopher Kings-Lynne , Gourish Singbal , Russell Smith , pgsql-performance@postgresql.org Subject: Re: column name is "LIMIT" In-reply-to: <4235DE36.2070608@Yahoo.com> References: <674d1f8a0503132314754df153@mail.gmail.com> <200503141825.22827.mr-russ@pws.com.au> <674d1f8a05031400482c413087@mail.gmail.com> <42355185.3070803@familyhealth.com.au> <1110824915.4281.123.camel@camel> <4235DE36.2070608@Yahoo.com> Comments: In-reply-to Jan Wieck message dated "Mon, 14 Mar 2005 13:55:50 -0500" Date: Mon, 14 Mar 2005 14:30:39 -0500 Message-ID: <29101.1110828639@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.007 tagged_above=0 required=5 tests=AWL X-Spam-Level: X-Archive-Number: 200503/278 X-Sequence-Number: 10983 Jan Wieck writes: > quote_ident() function doesn't quote reserved words ... as it IMHO is > supposed to do. You're right, it probably should. The equivalent code in pg_dump knows about this, but quote_ident() doesn't. One thing that's been on my mind with respect to all this is that it would be nice not to quote "non-reserved" keywords. Most of the weird non-SQL-spec keywords that we have are non-reserved, and we could more easily keep them out of people's faces if we didn't quote them in dumps. Of course such a policy would raise the ante for any change that makes an existing keyword reserved when it wasn't before, but that's already a dangerous kind of change. regards, tom lane