Received: from maia.hub.org (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id F04C863E824 for ; Tue, 2 Feb 2010 16:24:43 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 82810-02-3 for ; Tue, 2 Feb 2010 20:24:21 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id D415763441B for ; Tue, 2 Feb 2010 15:33:44 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id o12JXUls029130; Tue, 2 Feb 2010 14:33:30 -0500 (EST) To: Robert Haas cc: Andres Freund , Greg Stark , pgsql-hackers@postgresql.org, pgsql-performance@postgresql.org, Michael Clemmons , Hannu Krosing , Scott Marlowe Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) In-reply-to: <603c8f071002021106o5eef7b40r1ed21c9bd05251ec@mail.gmail.com> References: <4427a97a0912101235x3ade510blcc00d5ce9883c6b6@mail.gmail.com> <23321.1265133015@sss.pgh.pa.us> <603c8f071002021014h4b489f44s9014377e1b38dbc7@mail.gmail.com> <201002021934.18444.andres@anarazel.de> <603c8f071002021106o5eef7b40r1ed21c9bd05251ec@mail.gmail.com> Comments: In-reply-to Robert Haas message dated "Tue, 02 Feb 2010 14:06:32 -0500" Date: Tue, 02 Feb 2010 14:33:30 -0500 Message-ID: <29129.1265139210@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.465 tagged_above=-10 required=5 tests=AWL=0.134, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201002/27 X-Sequence-Number: 37448 Robert Haas writes: > Hmm, in that case, I think the problem is that this function has no > comment explaining its intended charter. That's certainly a big problem, but a comment won't fix the fact that the name is misleading. We need both a comment and a name change. regards, tom lane