X-Original-To: pgsql-hackers-win32-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 79C3254D3A; Mon, 7 Mar 2005 17:24:21 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 40904-08; Mon, 7 Mar 2005 17:24:19 +0000 (GMT) Received: from ct.radiology.uiowa.edu (ct.radiology.uiowa.edu [129.255.60.186]) by svr1.postgresql.org (Postfix) with ESMTP id 3EDBE56484; Mon, 7 Mar 2005 17:24:17 +0000 (GMT) Received: from [129.255.60.32] (natu.i-clic.uihc.uiowa.edu [129.255.60.32]) by ct.radiology.uiowa.edu (8.11.6/8.11.6) with ESMTP id j27HOC310274; Mon, 7 Mar 2005 11:24:12 -0600 Message-ID: <422C8E37.8000009@arbash-meinel.com> Date: Mon, 07 Mar 2005 11:24:07 -0600 From: John A Meinel User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tom Lane Cc: Magnus Hagander , Ken Egervari , pgsql-performance@postgresql.org, pgsql-hackers-win32@postgresql.org Subject: Re: [PERFORM] Help with tuning this query (with References: <6BCB9D8A16AC4241919521715F4D8BCE476A60@algol.sollentuna.se> <23086.1110206737@sss.pgh.pa.us> <422C817A.8050009@arbash-meinel.com> <2555.1110213531@sss.pgh.pa.us> In-Reply-To: <2555.1110213531@sss.pgh.pa.us> X-Enigmail-Version: 0.90.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFF8E46B93B8E65A5C48E5155" X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests= X-Spam-Level: X-Archive-Number: 200503/55 X-Sequence-Number: 3013 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFF8E46B93B8E65A5C48E5155 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Tom Lane wrote: >John A Meinel writes: > > >>>>Can we just replace gettimeofday() with a version that's basically: >>>> >>>> >>>No, because it's also used for actual time-of-day calls. It'd be >>>necessary to hack executor/instrument.c in particular. >>> >>> > > > >>Or we modify the win32 gettimeofday call to something like: >> >> > >That's what Magnus was talking about, but it's really no good because >it would cause Postgres' now() function to fail to track post-boot-time >changes in the system date setting. Which I think would rightly be >considered a bug. > >The EXPLAIN ANALYZE instrumentation code will really be happier with a >straight time-since-bootup counter; by using gettimeofday, it is >vulnerable to giving wrong answers if someone changes the date setting >while the EXPLAIN is running. But there is (AFAIK) no such call among >the portable Unix syscalls. It seems reasonable to me to #ifdef that >code to make use of QueryPerformanceCounter on Windows. This does not >mean we want to alter the behavior of gettimeofday() where it's being >used to find out the time of day. > > regards, tom lane > > > What if you changed the "initialized" to if (count & 0xFF == 0) { count = 1; // get the new time of day } ++count; Then we would only be wrong for 256 gettimeofday calls. I agree it isn't great, though. And probably better to just abstract (possibly just with #ifdef) the calls for accurate timing, from the calls that actually need the real time. John =:-> --------------enigFF8E46B93B8E65A5C48E5155 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCLI43JdeBCYSNAAMRAsOhAJ9D+CIcXiTShDZrxZE+E/TdNzqVWQCgiYza Nj8wY5Jaeewh9gDWDsvR+Io= =HBf/ -----END PGP SIGNATURE----- --------------enigFF8E46B93B8E65A5C48E5155--