X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id C8FD052818 for ; Mon, 27 Jun 2005 08:45:35 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 84842-03 for ; Mon, 27 Jun 2005 11:45:31 +0000 (GMT) Received: from trolak.mydnsbox2.com (ns1.mydnsbox2.com [207.44.142.118]) by svr1.postgresql.org (Postfix) with ESMTP id F083C52813 for ; Mon, 27 Jun 2005 08:45:28 -0300 (ADT) Received: from [192.168.1.103] (cpe-024-211-165-134.nc.res.rr.com [24.211.165.134]) (authenticated (0 bits)) by trolak.mydnsbox2.com (8.11.6/8.11.6) with ESMTP id j5RAx0121146; Mon, 27 Jun 2005 05:59:01 -0500 Message-ID: <42BFE6CF.1030101@dunslane.net> Date: Mon, 27 Jun 2005 07:45:19 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Fedora/1.7.8-1.3.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Luke Lonergan Cc: Alvaro Herrera , Bruce Momjian , Alon Goldshuv , pgsql-patches@postgresql.org Subject: Re: COPY FROM performance improvements References: <3E37B936B592014B978C4415F90D662D0C420B@MI8NYCMAIL06.Mi8.com> In-Reply-To: <3E37B936B592014B978C4415F90D662D0C420B@MI8NYCMAIL06.Mi8.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.025 tagged_above=0 required=5 tests=AWL X-Spam-Level: X-Archive-Number: 200506/512 X-Sequence-Number: 16244 Luke Lonergan wrote: >Yah - I think I fixed several mis-indented comments. I'm using vim with >tabstop=4. I personally don't like tabs in text and would prefer them >expanded using spaces, but that's a nice way to make small formatting >changes look huge in a cvs diff. > > > You might like to look at running pgindent (see src/tools/pgindent) over the file before cutting a patch. Since this is usually run over each file just before a release, the only badness should be things from recent patches. cheers andrew