Message-ID: <42C05F88.7000105@dunslane.net>
Date: Mon, 27 Jun 2005 16:20:24 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.7.8) Gecko/20050513 Fedora/1.7.8-1.3.1
MIME-Version: 1.0
To: Luke Lonergan <llonergan@greenplum.com>
Cc: Alvaro Herrera <alvherre@surnet.cl>,
	Bruce Momjian <pgman@candle.pha.pa.us>,
	Alon Goldshuv <agoldshuv@greenplum.com>, pgsql-patches@postgresql.org
Subject: Re: COPY FROM performance improvements
References: <BEE59901.7E8E%llonergan@greenplum.com>
In-Reply-To: <BEE59901.7E8E%llonergan@greenplum.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit


Luke Lonergan wrote:

>Andrew,
>
>  
>
>>You might like to look at running pgindent (see src/tools/pgindent) over
>>the file before cutting a patch. Since this is usually run over each
>>file just before a release, the only badness should be things from
>>recent patches.
>>    
>>
>
>I've attached two patches, one gained from running pgindent against the
>current CVS tip copy.c (:-D) and one gained by running the COPY FROM perf
>improvements through the same.  Nifty tool!
>
>Only formatting changes in these.
>
>  
>
>
Luke,

Something strange has happened. I suspect that you've inadvertantly used 
GNU indent or an unpatched BSD indent. pgindent needs a special patched 
BSD indent to work according to the PG standards - see the README

cheers

andrew