Message-ID: <42C1485E.3080008@dunslane.net>
Date: Tue, 28 Jun 2005 08:53:50 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.7.8) Gecko/20050513 Fedora/1.7.8-1.3.1
MIME-Version: 1.0
To: Luke Lonergan <llonergan@greenplum.com>
Cc: Alvaro Herrera <alvherre@surnet.cl>,
	Bruce Momjian <pgman@candle.pha.pa.us>,
	Alon Goldshuv <agoldshuv@greenplum.com>, pgsql-patches@postgresql.org
Subject: Re: COPY FROM performance improvements
References: <BEE623DE.7F0A%llonergan@greenplum.com>
In-Reply-To: <BEE623DE.7F0A%llonergan@greenplum.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Luke, Alon

OK, I'm going to apply the patch to my copy and try to get my head 
around it. meanwhile:

. we should not be describing things as "old" or "new".  The person 
reading the code might have no knowledge of the history, and should not 
need to.
. we should not have "slow" and "fast" either. We should have "text", 
"csv" and "binary".

IOW, the patch comments look slightly like it is intended for after the 
fact application rather than incorporation into the main code.

Are you looking at putting CSV mode into the fast code? Please let me 
know if you have questions about that. There are only a few days left to 
whip this into shape.

cheers

andrew

Luke Lonergan wrote:

>Andrew,
>
>  
>
>>Something strange has happened. I suspect that you've inadvertantly used
>>GNU indent or an unpatched BSD indent. pgindent needs a special patched
>>BSD indent to work according to the PG standards - see the README
>>    
>>
>
>OK - phew!  I generated new symbols for pgindent and fixed a bug in the awk
>scripting within (diff attached) and ran against the CVS tip copy.c and got
>only minor changes in formatting that appear to be consistent with the rest
>of the code.  I pgindent'ed the COPY FROM performance modded code and it
>looks good and tests good.
>
>Only formatting changes to the previous patch for copy.c attached.
>
>Patch to update pgindent with new symbols and fix a bug in an awk section
>(extra \\ in front of a ')').
>
>- Luke 
>
>  
>