Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UwxYX-0001am-1M for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jul 2013 16:47:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1UwxYW-0004ZT-Ea for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jul 2013 16:47:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UwxYV-0004Y6-68 for pgsql-hackers@postgresql.org; Wed, 10 Jul 2013 16:47:51 +0000 Received: from smtp.01.com ([199.36.142.181] helo=smtp-out-2.01.com) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UwxYQ-0004ZN-5N for pgsql-hackers@postgresql.org; Wed, 10 Jul 2013 16:47:50 +0000 Received: from localhost (localhost [127.0.0.1]) by smtp-out-2.01.com (Postfix) with ESMTP id 44FBC390120; Wed, 10 Jul 2013 11:47:43 -0500 (CDT) X-Virus-Scanned: amavisd-new at smtp-out-2.01.com Received: from smtp-out-2.01.com ([127.0.0.1]) by localhost (smtp-out-2.01.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A51fK23aRq5q; Wed, 10 Jul 2013 11:47:43 -0500 (CDT) Received: from smtp-out-2.01.com (localhost [127.0.0.1]) by smtp-out-2.01.com (Postfix) with ESMTP id 256AE390140; Wed, 10 Jul 2013 11:47:43 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by smtp-out-2.01.com (Postfix) with ESMTP id 14EE339013B; Wed, 10 Jul 2013 11:47:43 -0500 (CDT) X-Virus-Scanned: amavisd-new at smtp-out-2.01.com Received: from smtp-out-2.01.com ([127.0.0.1]) by localhost (smtp-out-2.01.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4JMYSDtSicZv; Wed, 10 Jul 2013 11:47:43 -0500 (CDT) Received: from [172.47.23.103] (70-36-143-10.dsl.dynamic.sonic.net [70.36.143.10]) by smtp-out-2.01.com (Postfix) with ESMTPSA id 9358C390120; Wed, 10 Jul 2013 11:47:40 -0500 (CDT) Message-ID: <51DD9026.2030107@agliodbs.com> Date: Wed, 10 Jul 2013 09:47:34 -0700 From: Josh Berkus Organization: PostgreSQL Experts Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Abhijit Menon-Sen CC: Simon Riggs , Mark Kirkwood , Tom Lane , Gavin Flower , pgsql-hackers@postgresql.org Subject: Re: [PERFORM] In progress INSERT wrecks plans on table References: <5179F5C6.8070702@archidevsys.co.nz> <5180E3C8.3010201@catalyst.net.nz> <2121.1367417215@sss.pgh.pa.us> <5181B80D.70404@catalyst.net.nz> <916bff05a5ab130c76d7835abbaf7762.squirrel@mail.catalyst.net.nz> <51870CB6.6090404@catalyst.net.nz> <20130624044350.GA32322@toroid.org> <51DAF2C8.6010705@agliodbs.com> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 07/08/2013 10:11 AM, Josh Berkus wrote: > On 06/23/2013 09:43 PM, Abhijit Menon-Sen wrote: >> (Cc: to pgsql-performance dropped, pgsql-hackers added.) >> >> At 2013-05-06 09:14:01 +0100, simon@2ndQuadrant.com wrote: >>> >>> New version of patch attached which fixes a few bugs. >> >> I read the patch, but only skimmed the earlier discussion about it. In >> isolation, I can say that the patch applies cleanly and looks sensible >> for what it does (i.e., cache pgprocno to speed up repeated calls to >> TransactionIdIsInProgress(somexid)). >> >> In that sense, it's ready for committer, but I don't know if there's a >> better/more complete/etc. way to address the original problem. > > Has this patch had performance testing? Because of the list crossover I > don't have any information on that. Due to the apparent lack of performance testing, I'm setting this back to "needs review". -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers