Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 85870634B3A; Tue, 2 Feb 2010 15:07:17 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 13803-04-7; Tue, 2 Feb 2010 19:07:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-bw0-f218.google.com (mail-bw0-f218.google.com [209.85.218.218]) by mail.postgresql.org (Postfix) with ESMTP id 87C2E63400F; Tue, 2 Feb 2010 15:06:35 -0400 (AST) Received: by bwz10 with SMTP id 10so425310bwz.35 for ; Tue, 02 Feb 2010 11:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=AvAGE5nbenoi4SEJWk2/LFuBxP4HtQKC7USCUGO2Eug=; b=Yce6Ns6uD01JjhMv5SG0gqOvOoQNWeJuE5dbQpeqe+0S+h6OQUifDwyQUXQ2vT7qI8 JZ02XjjZzn7JJxy2ZGOS+DEXQHz8iGnFUHOcswPnvUf3fCszDLl4XohKXXJDhHRhl4DE rMGJjzr6OQ2kYa3PwzgGSHP8DVfUxuQJmVU14= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ad41JaXAst0uugdG/Py7syoEXNNfS18EyMk/DvQuHkRYMhS7tI+8UQvijLVPb3EfhR TYnaPmIvJAbKi6nn/NY+/W968kxkT0QL4YIKtpeRmTW1oedVt2ImpSFA5NY18qgwi2G9 3KWVBaj5tRvKSVtKa5kwRs5WqI5w3/Q9IykQg= MIME-Version: 1.0 Received: by 10.239.182.81 with SMTP id p17mr745167hbg.117.1265137592316; Tue, 02 Feb 2010 11:06:32 -0800 (PST) In-Reply-To: <201002021934.18444.andres@anarazel.de> References: <4427a97a0912101235x3ade510blcc00d5ce9883c6b6@mail.gmail.com> <23321.1265133015@sss.pgh.pa.us> <603c8f071002021014h4b489f44s9014377e1b38dbc7@mail.gmail.com> <201002021934.18444.andres@anarazel.de> Date: Tue, 2 Feb 2010 14:06:32 -0500 Message-ID: <603c8f071002021106o5eef7b40r1ed21c9bd05251ec@mail.gmail.com> Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) From: Robert Haas To: Andres Freund Cc: Tom Lane , Greg Stark , pgsql-hackers@postgresql.org, pgsql-performance@postgresql.org, Michael Clemmons , Hannu Krosing , Scott Marlowe Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201002/22 X-Sequence-Number: 37443 On Tue, Feb 2, 2010 at 1:34 PM, Andres Freund wrote: > For now it could - but it very well might be converted to sync_file_range or > similar, which would have different "sideeffects". > > As the potential code duplication is rather small I would prefer to describe > the prime effect not the sideeffects... Hmm, in that case, I think the problem is that this function has no comment explaining its intended charter. ...Robert