Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id EF7DD63286B;
	Sun,  7 Feb 2010 14:23:22 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024)
	with ESMTP id 45529-05; Sun,  7 Feb 2010 18:23:01 +0000 (UTC)
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6
Received: from mail-fx0-f214.google.com (mail-fx0-f214.google.com
	[209.85.220.214])
	by mail.postgresql.org (Postfix) with ESMTP id CE75863249E;
	Sun,  7 Feb 2010 14:23:11 -0400 (AST)
Received: by fxm6 with SMTP id 6so4467120fxm.18
	for <multiple recipients>; Sun, 07 Feb 2010 10:23:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=aKPg6NhP4Cdw6oy68mNNNVvCXslDNlpuGftsJvj+BKo=;
	b=jcNTVxk+lRxTL3vI6If0SfaLw5rKLLud1048T+Obd7UF//hRLU7sUrbtVucLFN3yja
	LGNPRhqe/U18hM5NPI84AuLbuzHGw9WrTHGjMnuP76fkBAKr1DZKULkOcgzOi5fFAmmk
	wU1mvRK4BXrbyDZyCqmGt+RNDW0g2DzMoLHbE=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=NEtKV+W2XyyfTot16ulwF9NRCK8qD/pJKyOfVi5tAGViAEanG1K/2sFrd6PpOvF3JG
	zTqLB1eQZROBbmMuymBCxtGxYpXVHEalUghd77iIqAllEiagO2OpUb3MRfbsMBb4Q3PD
	crjcUgUHpFCFbL9S1j/1ID1XKSrbpHns+kF80=
MIME-Version: 1.0
Received: by 10.239.190.68 with SMTP id w4mr616583hbh.130.1265566990269; Sun,
	07 Feb 2010 10:23:10 -0800 (PST)
In-Reply-To: <24184.1265559840@sss.pgh.pa.us>
References: <4427a97a0912101235x3ade510blcc00d5ce9883c6b6@mail.gmail.com>
	<4B698605.50506@anarazel.de> <4B6CF822.9010608@2ndquadrant.com>
	<201002061304.01682.andres@anarazel.de>
	<603c8f071002062113k262dd8xcd0cdd482d2c6150@mail.gmail.com>
	<4B6E8682.7030006@2ndquadrant.com> <24184.1265559840@sss.pgh.pa.us>
Date: Sun, 7 Feb 2010 13:23:10 -0500
Message-ID: <603c8f071002071023v6d5329at6f80b453f472ebb3@mail.gmail.com>
Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1
	ubuntu karmic slow createdb)
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Smith <greg@2ndquadrant.com>, Andres Freund <andres@anarazel.de>,
	Greg Stark <gsstark@mit.edu>, pgsql-hackers@postgresql.org,
	pgsql-performance@postgresql.org,
	Michael Clemmons <glassresistor@gmail.com>,
	Hannu Krosing <hannu@2ndquadrant.com>,
	Scott Marlowe <scott.marlowe@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.472 tagged_above=-10 required=5 tests=AWL=0.127,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 201002/111
X-Sequence-Number: 37532

On Sun, Feb 7, 2010 at 11:24 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Greg Smith <greg@2ndquadrant.com> writes:
>> This is turning into yet another one of those situations where something
>> simple and useful is being killed by trying to generalize it way more
>> than it needs to be, given its current goals and its lack of external
>> interfaces. =A0There's no catversion bump or API breakage to hinder futu=
re
>> refactoring if this isn't optimally designed internally from day one.
>
> I agree that it's too late in the cycle for any major redesign of the
> patch. =A0But is it too much to ask to use a less confusing name for the
> function?

+1.  Let's just rename the thing, add some comments, and call it good.

...Robert