X-Original-To: pgsql-hackers@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id CEA9C475CA9 for ; Sun, 20 Apr 2003 13:09:28 -0400 (EDT) Received: from sss.pgh.pa.us (unknown [192.204.191.242]) by postgresql.org (Postfix) with ESMTP id 2BEB547580B for ; Sun, 20 Apr 2003 13:09:28 -0400 (EDT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.9/8.12.9) with ESMTP id h3KH9OU6006997; Sun, 20 Apr 2003 13:09:24 -0400 (EDT) To: Stephan Szabo Cc: Kevin Brown , pgsql-hackers@postgresql.org Subject: Re: [PERFORM] Foreign key performance In-reply-to: <20030420090304.F28973-200000@megazone23.bigpanda.com> References: <20030420090304.F28973-200000@megazone23.bigpanda.com> Comments: In-reply-to Stephan Szabo message dated "Sun, 20 Apr 2003 09:04:10 -0700" Date: Sun, 20 Apr 2003 13:09:24 -0400 Message-ID: <6996.1050858564@sss.pgh.pa.us> From: Tom Lane X-Spam-Status: No, hits=-32.3 required=5.0 tests=BAYES_00,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-Archive-Number: 200304/727 X-Sequence-Number: 38217 Stephan Szabo writes: > Okay, this changes the second paragraph of that comment. I left in the > comment that's really similar next to where I actually do the selection of > which start point to use. This had a bit of a problem yet: the loop in deferredTriggerInvokeEvents expects 'prev_event' to point to the list entry just before 'event'. A nice byproduct of fixing that is we don't uselessly rescan the last list entry. I also tried to improve the comments a little. You can see what I actually applied at http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/trigger.c regards, tom lane