X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (av.hub.org [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 7E5D9D9B4D for ; Tue, 4 Oct 2005 12:02:09 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 47321-01 for ; Tue, 4 Oct 2005 15:02:04 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id B1519D9FE3 for ; Tue, 4 Oct 2005 12:02:03 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id j94F20qI008304; Tue, 4 Oct 2005 11:02:00 -0400 (EDT) To: Martijn van Oosterhout Cc: Simon Riggs , Ron Peacetree , pgsql-hackers@postgresql.org Subject: Re: [PERFORM] A Better External Sort? In-reply-to: <20051004143041.GH17589@svana.org> References: <18329659.1128188552696.JavaMail.root@elwamui-polski.atl.sa.earthlink.net> <20051001215602.GG13830@svana.org> <29837.1128223567@sss.pgh.pa.us> <20051002123240.GA30492@svana.org> <20051002193835.GJ30492@svana.org> <1128376292.8603.142.camel@localhost.localdomain> <20051004100441.GC17589@svana.org> <1128425094.8603.296.camel@localhost.localdomain> <20051004122443.GF17589@svana.org> <7788.1128434784@sss.pgh.pa.us> <20051004143041.GH17589@svana.org> Comments: In-reply-to Martijn van Oosterhout message dated "Tue, 04 Oct 2005 16:30:42 +0200" Date: Tue, 04 Oct 2005 11:01:59 -0400 Message-ID: <8303.1128438119@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.006 required=5 tests=[AWL=0.006] X-Spam-Level: X-Archive-Number: 200510/178 X-Sequence-Number: 74037 Martijn van Oosterhout writes: > 1. Add -Winline so we can at least be aware of when it's (not) happening. Yeah, I agree with that part, just not with adding a fixed -finline-limit value. While on the subject of gcc warnings ... if I touch that code, I want to remove -Wold-style-definition from the default flags, too. It's causing much more clutter than it's worth, because all the flex files generate several such warnings. regards, tom lane