Received: from localhost (uranus.hub.org [200.46.204.60])
	by postgresql.org (Postfix) with ESMTP id 8A3C09FA5F0;
	Fri, 24 Nov 2006 15:17:44 -0400 (AST)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.60]) (amavisd-new, port 10024)
	with ESMTP id 90829-01-10; Fri, 24 Nov 2006 15:17:41 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.4
X-Greylist: from auto-whitelisted by SQLgrey-1.7.4
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by postgresql.org (Postfix) with ESMTP id 72D179FBD24;
	Fri, 24 Nov 2006 15:08:40 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id kAOJ8Yc0008865;
	Fri, 24 Nov 2006 14:08:34 -0500 (EST)
To: pgsql-hackers@postgresql.org, Bruce Momjian <bruce@momjian.us>
cc: Greg Smith <gsmith@gregsmith.com>,
	PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: [PERFORM] Direct I/O issues 
In-reply-to: <200611241858.kAOIwjh23094@momjian.us> 
References: <200611241858.kAOIwjh23094@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Fri, 24 Nov 2006 13:58:45 -0500"
Date: Fri, 24 Nov 2006 14:08:34 -0500
Message-ID: <8864.1164395314@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200611/116
X-Sequence-Number: 21646

Bruce Momjian <bruce@momjian.us> writes:
> Not sure if people want this for 8.2.  I think we can modify
> test_fsync.c anytime but the movement of the defines into an include
> file is a backend code change.

I think fooling with this on the day before RC1 is an unreasonable risk ...
and I disapprove of moving this code into a widely-used include file
like xlog.h, too.

			regards, tom lane