Message-ID: <9d6897bd-855d-44a6-8ebe-17b2b1d04430@uni-muenster.de>
Date: Mon, 15 Sep 2025 10:21:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: proposal: schema variables
To: Pavel Stehule <pavel.stehule@gmail.com>, Bruce Momjian <bruce@momjian.us>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>,
 Laurenz Albe <laurenz.albe@cybertec.at>, Erik Rijkers <er@xs4all.nl>,
 Michael Paquier <michael@paquier.xyz>, Amit Kapila
 <amit.kapila16@gmail.com>, DUVAL REMI <REMI.DUVAL@cheops.fr>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 jian he <jian.universality@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>, PegoraroF10 <marcos@f10.com.br>
References: 
 <CAFj8pRDJ9cq00VYSHxs6LsoHNWjhYXyWWBtV6UgeWwhs0AHa9A@mail.gmail.com>
 <CAFj8pRCRDhQobRx5FAZgK8drzA_T-9c67U_-wZJ2fmqwEVpFSQ@mail.gmail.com>
 <CAFj8pRB1VKs8DbymheidYXDC2i1ZShV+40J7h2j8GDfqM+yLbQ@mail.gmail.com>
 <CAFj8pRAMaiRSRyye9LdOTh_TgbwmohuXh7cCS9eSLtOUzCJU5Q@mail.gmail.com>
 <CAFj8pRBNj_+Q2CQjpURm5copeY27YPJz=Oa+rpRfa5DHu-j1iQ@mail.gmail.com>
 <CAFj8pRDiKxpZA1+dkGK-YW_H8oYp2hVOuFpOPHEkCBc5O4Z_ug@mail.gmail.com>
 <CAFj8pRAdUF6etyOK3UsAPu-1nuOpv6aHbFJuhtJO73uxC6vObw@mail.gmail.com>
 <CAFj8pRDdhYR66dNVz9WKKHDL64QK+CuqYM3yfiMR_Dp-uOm0bg@mail.gmail.com>
 <CAFj8pRDJdF=Jv6M1_ePV8tnzxBfyYHfHodeifhOUyMt1N-fxRQ@mail.gmail.com>
 <CAFj8pRAwp0ES9BKXbNocG_pYcqP0Cs2GdtGx_-2XsEe3fkCgdg@mail.gmail.com>
 <CAFj8pRAhnp63fV5m7ATr2_nW9_yVbFzwhL4Be8oTY_M0jksrXg@mail.gmail.com>
 <CAFj8pRBykx1Oh1JVzY5HfcZPjbGE5PH=DyPN4sM7fBafnNkLkA@mail.gmail.com>
 <CAFj8pRBx4w3QS0D2W3yc8hWXH7hynsOwO4x+iv4AstmB6Dmkgw@mail.gmail.com>
 <CAFj8pRBeF5Tz_DiKWokeEcRxrJR5FFDbTKhaaB-9TMYU3RYDfw@mail.gmail.com>
Content-Language: de-DE, en-GB
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: 
 <CAFj8pRBeF5Tz_DiKWokeEcRxrJR5FFDbTKhaaB-9TMYU3RYDfw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/9d6897bd-855d-44a6-8ebe-17b2b1d04430%40uni-muenster.de>
Precedence: bulk

Hi

On 9/13/25 11:28, Pavel Stehule wrote:
> 
> minor change (after private talk with Jim Jones)
> 

After another pass, there are a few additional tests that should be
included in this patch:


== Additional tests for GRANT x ON VARIABLE ==
==============================================

We wanna make sure the proper error message is raised.

postgres=# GRANT INSERT ON VARIABLE var TO jim;
ERROR:  invalid privilege type INSERT for session variable

postgres=# GRANT DELETE ON VARIABLE var TO jim;
ERROR:  invalid privilege type DELETE for session variable


== Tests for ALTER DEFAULT PRIVILEGES ==
========================================

I couldn't find regression tests for ALTER DEFAULT PRIVILEGES ... if I
haven't just missed them, I think they'd be a nice addition.

postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT UPDATE ON
VARIABLES TO jim;
ALTER DEFAULT PRIVILEGES

postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT INSERT ON
VARIABLES TO jim;
ERROR:  invalid privilege type INSERT for session variable

postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT DELETE ON
VARIABLES TO jim;
ERROR:  invalid privilege type DELETE for session variable

postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT SELECT ON
VARIABLES TO jim;
ALTER DEFAULT PRIVILEGES


Best, Jim