X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 760BB52C6D; Tue, 2 Aug 2005 12:03:54 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 20548-10; Tue, 2 Aug 2005 15:03:43 +0000 (GMT) Received: from mail.Mi8.com (nycgw05.mi8.com [63.240.6.46]) by svr1.postgresql.org (Postfix) with ESMTP id ADEBE52F23; Tue, 2 Aug 2005 12:03:40 -0300 (ADT) Received: from 172.16.1.110 by mail.Mi8.com with ESMTP (- GW05 Welcome to Mi8 Corporation www.Mi8.com); Tue, 02 Aug 2005 11:03:35 -0400 X-Server-Uuid: E0C866E6-C6CD-48B5-AE61-E57E73CF3CC7 Received: from MI8NYCMAIL06.Mi8.com ([172.16.1.175]) by D01SMTP01.Mi8.com with Microsoft SMTPSVC(6.0.3790.211); Tue, 2 Aug 2005 11:03:35 -0400 Received: from 141.156.39.156 ([141.156.39.156]) by MI8NYCMAIL06.Mi8.com ([172.16.1.219]) via Exchange Front-End Server mi8owa.mi8.com ( [172.16.1.104]) with Microsoft Exchange Server HTTP-DAV ; Tue, 2 Aug 2005 11:03:35 -0500 User-Agent: Microsoft-Entourage/11.1.0.040913 Date: Tue, 02 Aug 2005 11:03:44 -0400 Subject: Re: [PERFORM] COPY FROM performance improvements From: "Alon Goldshuv" To: pgsql-patches@postgresql.org, "pgsql-performance@postgresql.org" Message-ID: In-Reply-To: <26131.1122940270@sss.pgh.pa.us> MIME-Version: 1.0 X-OriginalArrivalTime: 02 Aug 2005 15:03:35.0747 (UTC) FILETIME=[5B39B930:01C59773] X-WSS-ID: 6EF154CD26S618902-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=1.569 tagged_above=0 required=5 tests=AWL, FORGED_RCVD_HELO, RCVD_NUMERIC_HELO X-Spam-Level: * X-Archive-Number: 200508/29 X-Sequence-Number: 16976 Tom, Thanks for pointing it out. I made the small required modifications to match copy.c version 1.247 and sent it to -patches list. New patch is V16. Alon. On 8/1/05 7:51 PM, "Tom Lane" wrote: > "Alon Goldshuv" writes: >>> This patch appears to reverse out the most recent committed changes in >>> copy.c. > >> Which changes do you refer to? I thought I accommodated all the recent >> changes (I recall some changes to the tupletable/tupleslot interface, HEADER >> in cvs, and hex escapes and maybe one or 2 more). What did I miss? > > The latest touch of copy.c, namely this patch: > > 2005-07-10 17:13 tgl > > * doc/src/sgml/ref/create_type.sgml, src/backend/commands/copy.c, > src/backend/commands/typecmds.c, src/backend/tcop/fastpath.c, > src/backend/tcop/postgres.c, src/backend/utils/adt/arrayfuncs.c, > src/backend/utils/adt/date.c, src/backend/utils/adt/numeric.c, > src/backend/utils/adt/rowtypes.c, > src/backend/utils/adt/timestamp.c, src/backend/utils/adt/varbit.c, > src/backend/utils/adt/varchar.c, src/backend/utils/adt/varlena.c, > src/backend/utils/mb/mbutils.c, src/include/catalog/catversion.h, > src/include/catalog/pg_proc.h, > src/test/regress/expected/type_sanity.out, > src/test/regress/sql/type_sanity.sql: Change typreceive function > API so that receive functions get the same optional arguments as > text input functions, ie, typioparam OID and atttypmod. Make all > the datatypes that use typmod enforce it the same way in typreceive > as they do in typinput. This fixes a problem with failure to > enforce length restrictions during COPY FROM BINARY. > > It was rather obvious, given that the first chunk of the patch backed up > the file's CVS version stamp from 1.247 to 1.246 :-( > > regards, tom lane >