MIME-Version: 1.0
References: 
 <CAFj8pRC+hPCc2X88xC=pTJoqmVPApDsageZOMyqaxi5788WxHA@mail.gmail.com>
 <CAFj8pRDJ9cq00VYSHxs6LsoHNWjhYXyWWBtV6UgeWwhs0AHa9A@mail.gmail.com>
 <CAFj8pRBPXTcw_3fpKtgVthV2+9rZGhxitZ40DnAwCrK601TZZg@mail.gmail.com>
 <ndtfl4tsnpkb7m7hwvnmlpsascpgd3a7xvjmjhtxffsbrgygtm@4du6zsmnnwq5>
 <CAFj8pRAu4XvNCGu1751t=2YEqLqTjDA3FavMExm2S0KYQq=DdQ@mail.gmail.com>
 <CAFj8pRAsEoeZv0HEnA8CKgFKDSQ-wYw18Os1vdksWCV7ez2bVw@mail.gmail.com>
 <3chredgnjcmccym2kczawfih226b4ac6co7p6z4jeofevrcosi@mrsxkx2x2c65>
 <CAFj8pRBoWPDTOwn5FmMzc+1qiopw+N04U26nviOdF61fs8A2wQ@mail.gmail.com>
 <stckyvkl4yyzvgjsaawojs3xikke7mmds5bhv7l7qerclywywk@h4v4n43xm6u2>
 <CAFj8pRB_E1GM_YGT-ti4bXka6mhLdAAFeTe+BHgHFYC+qb-76g@mail.gmail.com>
 <20241120201313.t4wbhld4ktgielaf@erthalion.local>
 <CAFj8pRBWqEb8i6WmrF_Xh64=48GtisKijgczMv7HTTpe4GswuA@mail.gmail.com>
 <CAFj8pRAry0esQiHcK=6BwwFKDY0zanug6k07CEQzRPBqZ6iW0Q@mail.gmail.com>
 <CACJufxFNjKrmyEi9SLfPCq4c9GUN+5eoOtbZwBPq9eKoO8REUw@mail.gmail.com>
 <CAFj8pRALQ-j-Dz3R1ivCoXut8LEhN+kSa7U8Gshucdv5zU3AfQ@mail.gmail.com>
 <CACJufxG7LvaNbF8ZSCcxOVUbm9W=KGjD=h_Wk+5imMw4s_2QxA@mail.gmail.com>
 <CAFj8pRBY_2awVdER5piyy_JPqsU1Sgr4HLO-v6C1nUS3dJnang@mail.gmail.com>
 <CACJufxEM=BLEn6YfgGonM7yuXMn7iqQJcH5PnDVbajWKanynfg@mail.gmail.com>
 <CAFj8pRBxA868TpLDe9ofXdpVUNmHY8pzkxrjbZ0obCe0g+YZ-Q@mail.gmail.com>
 <CACJufxEb1prZo4G4BhYym1VqKHaPVUv3SoggTR4uCqgCRY7Q-Q@mail.gmail.com>
 <CAFj8pRDK2heEhQNcwD=tcKpG5YyPu7zOz2jdRW5A5QfoSUEi_g@mail.gmail.com>
 <CACJufxEk16ArmFuTV9VYi6DJaZ+9Jrbt0-u0Zuov7sk-vpg_Dg@mail.gmail.com>
 <CAFj8pRAaoPCc=n_TPpWdOvzEdc96xfJZR8W7PphMLxLbGxAq-Q@mail.gmail.com>
 <CAFj8pRAzFCbTwqjaEvkvB0VBa9ofSEYxnv8wM3pHZTGtrRK0yQ@mail.gmail.com>
 <CACJufxFwxAvJL944UQKwxV1YuM3GQNTbPRQ6LwtioSKBfpMN2A@mail.gmail.com>
 <CAFj8pRAVoWzkx8Y3or-frYwszyLSjxzs9jYTm3rx00qN+21ZHg@mail.gmail.com>
 <CAFj8pRDhpDwWrV7DbwoGz=-i3yesEU1oooYyMErQfjMXKw=pOQ@mail.gmail.com>
 <CACJufxGdRAF=e57W3yd1cTrspB2bucnsr6ZfYY=bs+bfJWdRPw@mail.gmail.com>
 <CACJufxG6tFo1uOtTPoUw0ntzHddahd7EmR37DhsxMXxUixPaeQ@mail.gmail.com>
In-Reply-To: 
 <CACJufxG6tFo1uOtTPoUw0ntzHddahd7EmR37DhsxMXxUixPaeQ@mail.gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
Date: Mon, 6 Jan 2025 11:01:17 +0100
Message-ID: 
 <CAFj8pRBFpVZ7ZpB9G5MkePVFGHFRuq6b_iRufTg2HibX5hnzRA@mail.gmail.com>
Subject: Re: Re: proposal: schema variables
To: jian he <jian.universality@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
	Erik Rijkers <er@xs4all.nl>, Michael Paquier <michael@paquier.xyz>,
	Amit Kapila <amit.kapila16@gmail.com>, DUVAL REMI <REMI.DUVAL@cheops.fr>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f4bc1c062b06b75e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFj8pRBFpVZ7ZpB9G5MkePVFGHFRuq6b_iRufTg2HibX5hnzRA%40mail.gmail.com>
Precedence: bulk

--000000000000f4bc1c062b06b75e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

ne 5. 1. 2025 v 17:11 odes=C3=ADlatel jian he <jian.universality@gmail.com>
napsal:

> + /*
> + * The arguments of EXECUTE are evaluated by a direct expression
> + * executor call.  This mode doesn't support session variables yet.
> + * It will be enabled later.
> + */
> + if (pstate->p_hasSessionVariables)
> + elog(ERROR, "session variable cannot be used as an argument");
>
> it should be:
>     /*
>      * The arguments of CALL statement are evaluated by a direct expressi=
on
>      * executor call.  This path is unsupported yet, so block it.
>      */
>     if (pstate->p_hasSessionVariables)
>         ereport(ERROR,
>                 errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>                 errmsg("session variable cannot be used as an argument"))=
;
>
> done


>
> similarly, EvaluateParams we can change it to
>     /*
>      * The arguments of EXECUTE are evaluated by a direct expression
>      * executor call.  This mode doesn't support session variables yet.
>      * It will be enabled later.
>      */
>     if (pstate->p_hasSessionVariables)
>         ereport(ERROR,
>                 errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>                 errmsg("session variable cannot be used as an argument"))=
;
>

done


>
> in src/backend/executor/execExpr.c
> we don't need
> +#include "catalog/pg_variable.h"
> ?
>

moved to patch 16

--000000000000f4bc1c062b06b75e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">ne 5. 1. 2025 v=
=C2=A017:11 odes=C3=ADlatel jian he &lt;<a href=3D"mailto:jian.universality=
@gmail.com">jian.universality@gmail.com</a>&gt; napsal:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">+ /*<br>
+ * The arguments of EXECUTE are evaluated by a direct expression<br>
+ * executor call.=C2=A0 This mode doesn&#39;t support session variables ye=
t.<br>
+ * It will be enabled later.<br>
+ */<br>
+ if (pstate-&gt;p_hasSessionVariables)<br>
+ elog(ERROR, &quot;session variable cannot be used as an argument&quot;);<=
br>
<br>
it should be:<br>
=C2=A0 =C2=A0 /*<br>
=C2=A0 =C2=A0 =C2=A0* The arguments of CALL statement are evaluated by a di=
rect expression<br>
=C2=A0 =C2=A0 =C2=A0* executor call.=C2=A0 This path is unsupported yet, so=
 block it.<br>
=C2=A0 =C2=A0 =C2=A0*/<br>
=C2=A0 =C2=A0 if (pstate-&gt;p_hasSessionVariables)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ereport(ERROR,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 errcode(ERRCODE_FEA=
TURE_NOT_SUPPORTED),<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 errmsg(&quot;sessio=
n variable cannot be used as an argument&quot;));<br>
<br></blockquote><div>done</div><div>=C2=A0<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">
<br>
similarly, EvaluateParams we can change it to<br>
=C2=A0 =C2=A0 /*<br>
=C2=A0 =C2=A0 =C2=A0* The arguments of EXECUTE are evaluated by a direct ex=
pression<br>
=C2=A0 =C2=A0 =C2=A0* executor call.=C2=A0 This mode doesn&#39;t support se=
ssion variables yet.<br>
=C2=A0 =C2=A0 =C2=A0* It will be enabled later.<br>
=C2=A0 =C2=A0 =C2=A0*/<br>
=C2=A0 =C2=A0 if (pstate-&gt;p_hasSessionVariables)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ereport(ERROR,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 errcode(ERRCODE_FEA=
TURE_NOT_SUPPORTED),<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 errmsg(&quot;sessio=
n variable cannot be used as an argument&quot;));<br></blockquote><div><br>=
</div><div>done</div><div>=C2=A0<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex">
<br>
in src/backend/executor/execExpr.c<br>
we don&#39;t need<br>
+#include &quot;catalog/pg_variable.h&quot;<br>
?<br></blockquote><div><br></div><div>moved to patch 16</div><div>=C2=A0<br=
></div></div></div>

--000000000000f4bc1c062b06b75e--