public inbox for [email protected]  

help / color / mirror / Atom feed
From: Pavel Stehule <[email protected]>
To: Artur Zakirov <[email protected]>
Cc: Dean Rasheed <[email protected]>
Cc: Fabien COELHO <[email protected]>
Cc: Gilles Darold <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [HACKERS] proposal: schema variables
Date: Thu, 20 Sep 2018 11:08:57 +0200
Message-ID: <CAFj8pRCO+S9JVi+8L8MT7pcpz2+-orj5ju8k=e+PqZBhdYPhXg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAFj8pRCRUpNjX9Fb49SaADbRnCE69ndkOvtoeKxwvxetfJ8=kA@mail.gmail.com>
	<alpine.DEB.2.21.1808220831550.10677@lancre>
	<CAFj8pRCyvx37Fnw6yHdscGbbGo_Ak3WdeKiZ6arFW8JTA099YA@mail.gmail.com>
	<alpine.DEB.2.21.1808230927090.31897@lancre>
	<CAFj8pRAcFv09qOcbr09c2AbwZ9DGw5Hs6rPcYoo7r9OLdWWB2A@mail.gmail.com>
	<CAEZATCVy77hhgTZ1Yrvbp6GbsUuWY0Bw8CLbv_Jr2mAF_bOkBA@mail.gmail.com>
	<CAFj8pRDREykg0hnMBkryBmSTtqEs9QUKUp_447_F5P1j8bkH1w@mail.gmail.com>
	<CAFj8pRBkPswn0JA8U3vFOdBGqcBu0ZM7jC7JcDdCS1EbZfzb2A@mail.gmail.com>
	<CAFj8pRAi2Xd93ae-SsnMOC5W4hWenmkftTnCrHgdcPpvbOs1bg@mail.gmail.com>
	<CAFj8pRCZuq=0MRsYrNzBqxPx5fqmKFN3i-BsPo8j=yW6N_=WDA@mail.gmail.com>
	<[email protected]>

Hi

st 19. 9. 2018 v 13:23 odesílatel Arthur Zakirov <[email protected]>
napsal:

> Hello,
>
> On Wed, Sep 19, 2018 at 10:30:31AM +0200, Pavel Stehule wrote:
> > Hi
> >
> > new update:
> >
> > I fixed pg_restore, and I cleaned a code related to transaction
> processing
> >
> > There should be a full functionality now.
>
> I reviewed a little bit the patch. I have a few comments.
>
> > <title><structname>pg_views</structname> Columns</title>
>
> I think there is a typo here. It should be "pg_variable".
>

fixed


> > -     ONCOMMIT_DROP                           /* ON COMMIT DROP */
> > +     ONCOMMIT_DROP,                          /* ON COMMIT DROP */
> > } OnCommitAction;
>
> There is the extra comma here after ONCOMMIT_DROP.
>

fixed

Thank you for comments

attached updated patch




> 1 - https://www.postgresql.org/docs/current/static/sql-createtable.html
>
> --
> Arthur Zakirov
> Postgres Professional: http://www.postgrespro.com
> Russian Postgres Company
>


Attachments:

  [application/gzip] schema-variables-20180920-01.patch.gz (64.5K, 3-schema-variables-20180920-01.patch.gz)
  download

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [HACKERS] proposal: schema variables
  In-Reply-To: <CAFj8pRCO+S9JVi+8L8MT7pcpz2+-orj5ju8k=e+PqZBhdYPhXg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox