MIME-Version: 1.0
References: <Z4pmKI2yodbDn5vw@momjian.us>
 <202501171447.ujcoco7hy4oh@alvherre.pgsql>
In-Reply-To: <202501171447.ujcoco7hy4oh@alvherre.pgsql>
From: Pavel Stehule <pavel.stehule@gmail.com>
Date: Mon, 20 Jan 2025 09:26:11 +0100
Message-ID: 
 <CAFj8pRDDizf70=U6H+=O22mqQcVXB40vzvb-bsw4qsegzYdSXg@mail.gmail.com>
Subject: Re: Re: proposal: schema variables
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: Bruce Momjian <bruce@momjian.us>, jian he <jian.universality@gmail.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
	Erik Rijkers <er@xs4all.nl>, Michael Paquier <michael@paquier.xyz>,
	Amit Kapila <amit.kapila16@gmail.com>, DUVAL REMI <REMI.DUVAL@cheops.fr>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000008d49ff062c1f0531"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFj8pRDDizf70%3DU6H%2B%3DO22mqQcVXB40vzvb-bsw4qsegzYdSXg%40mail.gmail.com>
Precedence: bulk

--0000000000008d49ff062c1f0531
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

po 20. 1. 2025 v 8:56 odes=C3=ADlatel =C3=81lvaro Herrera <alvherre@alvh.no=
-ip.org>
napsal:

> On 2025-Jan-17, Bruce Momjian wrote:
>
> > Is this really something we are considering applying, since it has been
> > around for years?  I am unclear on that and we had better know if we ar=
e
> > going to continue reviewing this.
>
> The fact that the patch has been around for years doesn't automatically
> mean it's a bad idea.
>
> I have proposed that we discuss this patch at fosdem developer's meeting
> next month, precisely to seek consensus on whether this patch is
> something we want or not.  My view is that this is a feature that has
> been requested by users for years, so IMO we want this or something
> similar.
>
> I wonder if the reason that committers stay away from it is that
> reviewing it fully (and thus taking responsibility for it) seems such a
> daunting task.  I might be wrong, but I think this may be the largest
> patch since FTS.
>

This patch is huge, but I think it is not comparable with parallel
processing support or with replication support.

It doesn't introduce new processes or new data structures or does important
changes in planner, and I think so almost all code is very simple.

In early versions of this patch, there was a complex part to ensure
validity of content in memory. But it was fully removed and replaced
just by comparing with create_lsn.

Regards

Pavel


> --
> =C3=81lvaro Herrera               48=C2=B001'N 7=C2=B057'E  =E2=80=94
> https://www.EnterpriseDB.com/
> Tom: There seems to be something broken here.
> Teodor: I'm in sackcloth and ashes...  Fixed.
>
> http://postgr.es/m/482D1632.8010507@sigaev.ru
>

--0000000000008d49ff062c1f0531
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi<br></div><br><div class=3D"gmail_quote gmail_quote=
_container"><div dir=3D"ltr" class=3D"gmail_attr">po 20. 1. 2025 v=C2=A08:5=
6 odes=C3=ADlatel =C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@alvh.n=
o-ip.org">alvherre@alvh.no-ip.org</a>&gt; napsal:<br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">On 2025-Jan-17, Bruce Momjian wrote:<br>
<br>
&gt; Is this really something we are considering applying, since it has bee=
n<br>
&gt; around for years?=C2=A0 I am unclear on that and we had better know if=
 we are<br>
&gt; going to continue reviewing this.<br>
<br>
The fact that the patch has been around for years doesn&#39;t automatically=
<br>
mean it&#39;s a bad idea.<br>
<br>
I have proposed that we discuss this patch at fosdem developer&#39;s meetin=
g<br>
next month, precisely to seek consensus on whether this patch is<br>
something we want or not.=C2=A0 My view is that this is a feature that has<=
br>
been requested by users for years, so IMO we want this or something<br>
similar.<br>
<br>
I wonder if the reason that committers stay away from it is that<br>
reviewing it fully (and thus taking responsibility for it) seems such a<br>
daunting task.=C2=A0 I might be wrong, but I think this may be the largest<=
br>
patch since FTS.<br></blockquote></div><div class=3D"gmail_quote gmail_quot=
e_container"><br></div><div class=3D"gmail_quote gmail_quote_container">Thi=
s patch is huge, but I think it is not comparable with parallel processing =
support or with replication support.</div><div class=3D"gmail_quote gmail_q=
uote_container"><br></div><div class=3D"gmail_quote gmail_quote_container">=
It doesn&#39;t introduce new processes or new data structures or does impor=
tant changes in planner, and I think so almost all code is very simple. <br=
></div><div class=3D"gmail_quote gmail_quote_container"><br></div><div clas=
s=3D"gmail_quote gmail_quote_container">In early versions of this patch, th=
ere was a complex part to ensure validity of content in memory. But it was =
fully removed and replaced</div><div class=3D"gmail_quote gmail_quote_conta=
iner">just by comparing with create_lsn.</div><div class=3D"gmail_quote gma=
il_quote_container"><br></div><div class=3D"gmail_quote gmail_quote_contain=
er">Regards</div><div class=3D"gmail_quote gmail_quote_container"><br></div=
><div class=3D"gmail_quote gmail_quote_container">Pavel<br></div><div class=
=3D"gmail_quote gmail_quote_container"><br></div><div class=3D"gmail_quote =
gmail_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
=C3=81lvaro Herrera=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A04=
8=C2=B001&#39;N 7=C2=B057&#39;E=C2=A0 =E2=80=94=C2=A0 <a href=3D"https://ww=
w.EnterpriseDB.com/" rel=3D"noreferrer" target=3D"_blank">https://www.Enter=
priseDB.com/</a><br>
Tom: There seems to be something broken here.<br>
Teodor: I&#39;m in sackcloth and ashes...=C2=A0 Fixed.<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"http://postgr.es/m/482D163=
2.8010507@sigaev.ru" rel=3D"noreferrer" target=3D"_blank">http://postgr.es/=
m/482D1632.8010507@sigaev.ru</a><br>
</blockquote></div></div>

--0000000000008d49ff062c1f0531--