X-Original-To: pgsql-php@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id 33211474E4F for ; Sat, 22 Mar 2003 18:02:50 -0500 (EST) Received: from seapdc01.PNTS (ip63.c216.blk1.bel.nwlink.com [209.20.216.63]) by postgresql.org (Postfix) with ESMTP id 98BBE474E44 for ; Sat, 22 Mar 2003 18:02:49 -0500 (EST) Received: from busbydev (BUSBY-DEV [10.0.0.64]) by seapdc01.PNTS with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2653.13) id 19TL1XB6; Sat, 22 Mar 2003 15:13:35 -0800 Message-ID: <001201c2f0c6$a6032510$4000000a@busbydev> Reply-To: "David Busby" From: "David Busby" To: References: <20030322220944.GB416@ssbeagle> Subject: Re: volunteer/peer review request Date: Sat, 22 Mar 2003 14:58:56 -0800 Organization: Pacific Northwest Ticket Services MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-Spam-Status: No, hits=-12.9 required=5.0 tests=ORIGINAL_MESSAGE,QUOTED_EMAIL_TEXT,REFERENCES autolearn=ham version=2.50-cvs X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50-cvs (1.172-2003-02-14-exp) X-Archive-Number: 200303/33 X-Sequence-Number: 1945 Usally on a fatal error (like no DB connection) in place of if ($conn) { // Stuff } else { // Error } I use if (!$conn) { $err = "No DB Conn"; close_page($err) } The "close_page($err);" is a call to a function I wote that will dump the error string (or what ever paramter) and then finish the HTML for me. /B ----- Original Message ----- From: To: Sent: Saturday, March 22, 2003 14:09 Subject: [PHP] volunteer/peer review request > I trust and value the opinions of the members of this list. Please give > me some constructive criticism on the following code: > > http://webdevel.urban.csuohio.edu/lcua_pub/reveal_pub_retrieve.php > > Sorry, no control over the colors, if you want plain vanilla: > > http://webdevel.urban.csuohio.edu/lcua_pub/pub_retrieve.inc > > > I have placed comments and cleaned up to the line: > > elseif (array_search('submit', $_GET) == "keyword") > > > Please let me know if this code: > > 1) makes sense > 2) is readable > 3) is robust > 4) is flexible > 5) and anything else you want to tell me (well, anything helpful and > constructive). > > I am a sole PHP/postgresql programmer in a college full of people who want to > do projects that would involve this as a model. > > This is by no means a finished product, it is simply a beginning tool to > get us all started and acclimated here to internet interfaces to > database backends. > > I'm comfortable with PHP, but am no professional. My learning tool is > the documentation that came with both PostgreSQL and PHP, as well as a > few Zend tutorials. > > Thank you, > -- > -- > Chadwick Rolfs > > > ---------------------------(end of broadcast)--------------------------- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/docs/faqs/FAQ.html