Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 7F8826329D1; Wed, 21 Oct 2009 05:52:55 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 55153-08; Wed, 21 Oct 2009 08:52:39 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.ecircle.de (mail.ecircle.de [195.140.186.200]) by mail.postgresql.org (Postfix) with ESMTP id 3DE416329BB; Wed, 21 Oct 2009 05:52:44 -0300 (ADT) Received: from humboldt.muc.ecircle.de (humboldt.muc.ecircle.de [192.168.66.207]) by mail.ecircle.de (READY) with ESMTP id C15D960C50F; Wed, 21 Oct 2009 10:52:42 +0200 (CEST) Received: from [192.168.99.65] (192.168.99.65) by humboldt.muc.ecircle.de (192.168.66.207) with Microsoft SMTP Server id 8.2.176.0; Wed, 21 Oct 2009 10:54:23 +0200 Subject: Re: PostgreSQL driver for Joomla review From: Csaba Nagy To: Thom Brown CC: "reid.thompson@ateb.com" , "pgsql-php@postgresql.org" , "pgsql-general@postgresql.org" In-Reply-To: References: <1256043135.3362.488.camel@pcd12478> <1256044824.28209.3.camel@raker.ateb.com> Content-Type: text/plain Date: Wed, 21 Oct 2009 10:52:42 +0200 Message-ID: <1256115162.3362.596.camel@pcd12478> MIME-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-8.0.0.1307-5.600.1016-16960.003 X-TM-AS-Result: No--28.733000-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-0.649 tagged_above=-10 required=5 tests=AWL=-0.650, BAYES_50=0.001 X-Spam-Level: X-Archive-Number: 200910/786 X-Sequence-Number: 154480 Hi Thom, Sorry for the delay, I got sick in the meantime. I see that others already did some review, I will do a quick one too, later maybe I'll actually try it out... so after a quick review: * on line 218, the " ENCODING '$DBname')" part feels wrong, you probably want hardcoded UTF8 encoding there ? * as Merlin already commented, transactions are always safe in postgres, this is no mysql ;-) * again, as Merlin commented, getTableList is getting the data bases, which doesn't make sense, but maybe you actually wanted to get the tables - in this case you don't have a typo but you need to change the query ;-) If I'll get some time I'll test it too, but likely not this week... Cheers, Csaba. On Tue, 2009-10-20 at 15:28 +0200, Thom Brown wrote: > 2009/10/20 Reid Thompson : > > your attachment contains this... > > > > > > > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> > > > > > > 403 - Forbidden > > > > > >

403 - Forbidden

> > > > > > > > Erk.. that's weird. I got that too even after being logged in. I'm > not sure how anyone can review it if no-one has access to it. > > I've attached my working version which differs only slightly to > conform with coding-styles required by Joomla. > > Apologies > > Thom