X-Original-To: pgsql-php@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id 8B17F4758F1 for ; Sat, 22 Mar 2003 17:09:57 -0500 (EST) Received: from wolf.urban.csuohio.edu (wolf.urban.csuohio.edu [137.148.96.16]) by postgresql.org (Postfix) with ESMTP id 08C40474E4F for ; Sat, 22 Mar 2003 17:09:57 -0500 (EST) Received: from ssbeagle (urbanpub97-123.dhcp.csuohio.edu [137.148.97.123]) by wolf.urban.csuohio.edu (8.12.8/8.12.7) with ESMTP id h2MM9oOd000091 for ; Sat, 22 Mar 2003 17:09:50 -0500 (EST) Received: from cmr by ssbeagle with local (Exim 3.36 #1 (Debian)) id 18wrBQ-0000Bw-00 for ; Sat, 22 Mar 2003 17:09:44 -0500 Date: Sat, 22 Mar 2003 17:09:44 -0500 From: cmr@shell.gis.net To: pgsql-php@postgresql.org Subject: volunteer/peer review request Message-ID: <20030322220944.GB416@ssbeagle> Reply-To: pgsql-php@postgresql.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.3i X-MailScanner: Found to be clean X-Spam-Status: No, hits=-5.7 required=5.0 tests=NO_REAL_NAME,USER_AGENT_MUTT autolearn=ham version=2.50-cvs X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50-cvs (1.172-2003-02-14-exp) X-Archive-Number: 200303/32 X-Sequence-Number: 1944 I trust and value the opinions of the members of this list. Please give me some constructive criticism on the following code: http://webdevel.urban.csuohio.edu/lcua_pub/reveal_pub_retrieve.php Sorry, no control over the colors, if you want plain vanilla: http://webdevel.urban.csuohio.edu/lcua_pub/pub_retrieve.inc I have placed comments and cleaned up to the line: elseif (array_search('submit', $_GET) == "keyword") Please let me know if this code: 1) makes sense 2) is readable 3) is robust 4) is flexible 5) and anything else you want to tell me (well, anything helpful and constructive). I am a sole PHP/postgresql programmer in a college full of people who want to do projects that would involve this as a model. This is by no means a finished product, it is simply a beginning tool to get us all started and acclimated here to internet interfaces to database backends. I'm comfortable with PHP, but am no professional. My learning tool is the documentation that came with both PostgreSQL and PHP, as well as a few Zend tutorials. Thank you, -- -- Chadwick Rolfs