Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 5307D632CE4 for ; Mon, 4 May 2009 17:57:10 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 44333-05 for ; Mon, 4 May 2009 17:57:08 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.potentialtech.com (internet.potentialtech.com [66.167.251.6]) by mail.postgresql.org (Postfix) with ESMTP id EB209632B5E for ; Mon, 4 May 2009 17:57:07 -0300 (ADT) Received: from vanquish.ws.pitbpa0.priv.collaborativefusion.com (pr40.pitbpa0.pub.collaborativefusion.com [206.210.89.202]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.potentialtech.com (Postfix) with ESMTPSA id 122B8EBC0A; Mon, 4 May 2009 16:57:06 -0400 (EDT) Date: Mon, 4 May 2009 16:57:04 -0400 From: Bill Moran To: Kenneth Marshall Cc: ljb , pgsql-php@postgresql.org Subject: Re: pg_transaction_status() unreliable?! Message-Id: <20090504165704.b8a0027d.wmoran@potentialtech.com> In-Reply-To: <20090504194806.GC13811@it.is.rice.edu> References: <20090501170302.2eb5eb84.wmoran@potentialtech.com> <20090504153421.2e940587.wmoran@potentialtech.com> <20090504194806.GC13811@it.is.rice.edu> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.14.7; i386-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=1.333 tagged_above=0 required=5 tests=PLING_QUERY=1.333 X-Spam-Level: * X-Archive-Number: 200905/4 X-Sequence-Number: 4024 In response to Kenneth Marshall : > On Mon, May 04, 2009 at 03:34:21PM -0400, Bill Moran wrote: > > In response to ljb : > > > > > wmoran@potentialtech.com wrote: > > > > > > > > I'm having some ugly fun here. It doesn't seem as if > > > > pg_transaction_status() is reliable in the least. > > > > > > > > For example, I'm doing the equivalent of the following: > > > > > > > > pg_send_query_params($conn, 'BEGIN', array()); > > > > pg_get_result($conn); > > > > ... some other queries, each using pg_send_query_params() and > > > > pg_get_result() ... > > > > pg_send_query_params($conn, 'COMMIT', array()); > > > > pg_get_result($conn); > > > > echo pg_transaction_status($conn); > > > > > > > > Now, amazingly enough, pg_transaction_status() returns > > > > PGSQL_TRANSACTION_ACTIVE after the commit. This makes no sense to > > > > me at all ... it should return PGSQL_TRANSACTION_IDLE, since the > > > > connection is no longer in a transaction. > > > > > > > > Is anyone else seeing this? I have assertions failing all over the > > > > place because my code thinks that transactions have been left > > > > uncommitted. > > > > > > One needs to loop on pg_get_result() until it returns False. Are you doing > > > this? > > > > No. There's no documented reason that I can see to do so ;) > > > Here is the statement in that manual to which he is referring: > > PQgetResult > > Waits for the next result from a prior PQsendQuery, PQsendQueryParams, > PQsendPrepare, or PQsendQueryPrepared call, and returns it. A null > pointer is returned when the command is complete and there will be no > more results. > > PGresult *PQgetResult(PGconn *conn); > > > PQgetResult must be called repeatedly until it returns a null pointer, > indicating that the command is done. (If called when no command is > active, PQgetResult will just return a null pointer at once.) Each > non-null result from PQgetResult should be processed using the same > PGresult accessor functions previously described. Don't forget to > free each result object with PQclear when done with it. Note that > PQgetResult > > ... Not that it says anything about PQtransactionStatus being affected by the use of it. If I read this literally, PQgetResult could return a result set that is incomplete, which begs the question: how do I merge the remaining part of the result set when I get it back next time? Of course, that's not the intended usage, which leads me to wonder what's going on when I know factually that I have no more query results pending, yet I have to call it again (apparently) to update the client's internal status data structures. Oh well, I guess that's just the quirks of the client library. -- Bill Moran http://www.potentialtech.com http://people.collaborativefusion.com/~wmoran/